widevine-partner/android
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Correct openssl error logging

Browse Source 
[ Merge of http://go/wvgerrit/29041/ ]

Releasing allocated BIO buffers before logging failure causes the
openssl error to be erased.

b/62486203

Test: Ran WV unit, integration tests on angler

Change-Id: I3315edae2d3bd34887569ab88817f9591c12f409
This commit is contained in:
Rahul Frias
2017-06-24 16:31:59 -07:00
parent a6bc2c61e1
commit 0dbc087eab
1 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
libwvdrmengine/cdm/core/src/privacy_crypto_openssl.cpp
View File

@@ -29,14 +29,15 @@ RSA* GetKey(const std::string& serialized_key) {
return NULL; return NULL;
} }
RSA* key = d2i_RSAPublicKey_bio(bio, NULL); RSA* key = d2i_RSAPublicKey_bio(bio, NULL);
BIO_free(bio);
if (key == NULL) { if (key == NULL) {
LOGE("GetKey: RSA key deserialization failure: %s", LOGE("GetKey: RSA key deserialization failure: %s",
ERR_error_string(ERR_get_error(), NULL)); ERR_error_string(ERR_get_error(), NULL));
BIO_free(bio);
return NULL; return NULL;
} }
BIO_free(bio);
return key; return key;
} }