From 2999e4588e034219a540fa099102d7916dc53db0 Mon Sep 17 00:00:00 2001 From: Alex Dale Date: Wed, 20 Jul 2022 14:45:51 -0700 Subject: [PATCH] Fix 31 ClangTidyBuild findings: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit [ Merge of http://go/wvgerrit/151597 ] * missing #include for 'std::string' For more info see go/clang_tidy/checks/google3-build-missing-std-includes (25 times) * missing #include for 'std::move' For more info see go/clang_tidy/checks/google3-build-missing-std-includes (3 times) * missing #include for 'std::find_if' For more info see go/clang_tidy/checks/google3-build-missing-std-includes (2 times) * missing #include for 'std::sort' For more info see go/clang_tidy/checks/google3-build-missing-std-includes This CL looks good? Just LGTM and Approve it! This CL doesn’t look good? This is what you can do: * Revert this CL, by replying "REVERT: " * File a bug under go/clang-tidy-bug for category ClangTidyBuild if there's an issue with the CL content. * File a bug under go/rosie-bug if there's an issue with how the CL was managed. * Revert this CL and not get a CL that cleans up these paths in the future by replying "BLOCKLIST: ". This is not reversible! We recommend to opt out the respective paths in your CL Robot configuration instead: go/clrobot-opt-out. This CL was generated by CL Robot - a tool that cleans up code findings (go/clrobot). The affected code paths have been enabled for CL Robot in //depot/google3/METADATA. Anything wrong with the signup? File a bug at go/clrobot-bug. Bug: 236317198 Change-Id: I28f7899b5cf0637be15833659f8ba0dd6ff3ab90 --- libwvdrmengine/oemcrypto/odk/include/odk_structs.h | 2 +- libwvdrmengine/oemcrypto/odk/test/odk_core_message_test.cpp | 2 ++ libwvdrmengine/oemcrypto/odk/test/odk_test.cpp | 1 + libwvdrmengine/oemcrypto/odk/test/odk_test_helper.cpp | 1 + 4 files changed, 5 insertions(+), 1 deletion(-) diff --git a/libwvdrmengine/oemcrypto/odk/include/odk_structs.h b/libwvdrmengine/oemcrypto/odk/include/odk_structs.h index ac9b0283..9ad548a0 100644 --- a/libwvdrmengine/oemcrypto/odk/include/odk_structs.h +++ b/libwvdrmengine/oemcrypto/odk/include/odk_structs.h @@ -19,7 +19,7 @@ extern "C" { #define ODK_MINOR_VERSION 0 /* ODK Version string. Date changed automatically on each release. */ -#define ODK_RELEASE_DATE "ODK v17.0 2022-04-19" +#define ODK_RELEASE_DATE "ODK v17.0 2022-05-06" /* The lowest version number for an ODK message. */ #define ODK_FIRST_VERSION 16 diff --git a/libwvdrmengine/oemcrypto/odk/test/odk_core_message_test.cpp b/libwvdrmengine/oemcrypto/odk/test/odk_core_message_test.cpp index 24fbe6da..22051b22 100644 --- a/libwvdrmengine/oemcrypto/odk/test/odk_core_message_test.cpp +++ b/libwvdrmengine/oemcrypto/odk/test/odk_core_message_test.cpp @@ -2,6 +2,8 @@ // source code may only be used and distributed under the Widevine // License Agreement. +#include + #include "OEMCryptoCENCCommon.h" #include "gtest/gtest.h" #include "odk.h" diff --git a/libwvdrmengine/oemcrypto/odk/test/odk_test.cpp b/libwvdrmengine/oemcrypto/odk/test/odk_test.cpp index d1a817d8..8eaa0a12 100644 --- a/libwvdrmengine/oemcrypto/odk/test/odk_test.cpp +++ b/libwvdrmengine/oemcrypto/odk/test/odk_test.cpp @@ -6,6 +6,7 @@ #include #include +#include #include "OEMCryptoCENCCommon.h" #include "core_message_deserialize.h" diff --git a/libwvdrmengine/oemcrypto/odk/test/odk_test_helper.cpp b/libwvdrmengine/oemcrypto/odk/test/odk_test_helper.cpp index c1cf4658..928318d3 100644 --- a/libwvdrmengine/oemcrypto/odk/test/odk_test_helper.cpp +++ b/libwvdrmengine/oemcrypto/odk/test/odk_test_helper.cpp @@ -9,6 +9,7 @@ #include #include #include +#include #include #include "OEMCryptoCENCCommon.h"