Merge Widevine CDM-Side Test Changes

This is a combined merge of several small test changes in the
Widevine CDM repository:

http://go/wvgerrit/11252
  Chain CreateSession() Helpers in CDM Session Unit Test

http://go/wvgerrit/10931
  Increase URLRequest timeouts and tolerate 502's.

http://go/wvgerrit/10695
  Remove dead CHROMIUM_BUILD code in engine test.

Change-Id: I75a6c9509880a20c85e54cbd2fcbf34b101ce70e
This commit is contained in:
John "Juce" Bruce
2015-03-04 12:39:06 -08:00
parent 2ae1f717f3
commit 33ddce2298
4 changed files with 10 additions and 16 deletions

View File

@@ -9,10 +9,6 @@
#include <string> #include <string>
#if defined(CHROMIUM_BUILD)
#include "base/at_exit.h"
#include "base/message_loop/message_loop.h"
#endif
#include "cdm_engine.h" #include "cdm_engine.h"
#include "config_test_env.h" #include "config_test_env.h"
#include "gtest/gtest.h" #include "gtest/gtest.h"
@@ -300,9 +296,5 @@ int main(int argc, char **argv) {
g_key_id_pssh); g_key_id_pssh);
g_key_id_unwrapped = extractor.data(); g_key_id_unwrapped = extractor.data();
#if defined(CHROMIUM_BUILD)
base::AtExitManager exit;
base::MessageLoop ttr(base::MessageLoop::TYPE_IO);
#endif
return RUN_ALL_TESTS(); return RUN_ALL_TESTS();
} }

View File

@@ -135,10 +135,7 @@ class CdmSessionTest : public ::testing::Test {
if (cdm_session_) delete cdm_session_; if (cdm_session_) delete cdm_session_;
} }
void CreateSession() { void CreateSession() { CreateSession(NULL); }
cdm_session_ = new CdmSession(license_parser_, crypto_session_,
policy_engine_, file_handle_, NULL);
}
void CreateSession(const CdmClientPropertySet* cdm_client_property_set) { void CreateSession(const CdmClientPropertySet* cdm_client_property_set) {
cdm_session_ = cdm_session_ =

View File

@@ -73,8 +73,14 @@ void ConcatenateChunkedResponse(const std::string http_response,
namespace wvcdm { namespace wvcdm {
UrlRequest::UrlRequest(const std::string& url) UrlRequest::UrlRequest(const std::string& url)
: is_connected_(false), : is_connected_(false), socket_(url) {
socket_(url) { Reconnect();
}
UrlRequest::~UrlRequest() {}
void UrlRequest::Reconnect() {
socket_.CloseSocket();
if (socket_.Connect(kConnectTimeoutMs)) { if (socket_.Connect(kConnectTimeoutMs)) {
is_connected_ = true; is_connected_ = true;
} else { } else {
@@ -83,8 +89,6 @@ UrlRequest::UrlRequest(const std::string& url)
} }
} }
UrlRequest::~UrlRequest() {}
bool UrlRequest::GetResponse(std::string* message) { bool UrlRequest::GetResponse(std::string* message) {
std::string response; std::string response;

View File

@@ -17,6 +17,7 @@ class UrlRequest {
~UrlRequest(); ~UrlRequest();
bool is_connected() const { return is_connected_; } bool is_connected() const { return is_connected_; }
void Reconnect();
bool PostRequest(const std::string& data); bool PostRequest(const std::string& data);
bool PostCertRequestInQueryString(const std::string& data); bool PostCertRequestInQueryString(const std::string& data);