Remove extra copy operations identified by Coverity

Change-Id: I5e900082d3b17300f3a4ef95561d04c0228aba4f

libwvdrmengine/cdm/core/src/cdm_engine.cpp

@@ -95,7 +95,9 @@ class UsagePropertySet : public CdmClientPropertySet {
 
 CdmEngine::CdmEngine(wvutil::FileSystem* file_system,
                      std::shared_ptr<metrics::EngineMetrics> metrics)
-    : metrics_(metrics), file_system_(file_system), spoid_(EMPTY_SPOID) {
+    : metrics_(std::move(metrics)),
+      file_system_(file_system),
+      spoid_(EMPTY_SPOID) {
   assert(file_system);
   Properties::Init();
 }
@@ -712,7 +714,7 @@ CdmResponseType CdmEngine::QueryStatus(RequestedSecurityLevel security_level,
       LOGW("GetWVCdmVersion failed");
       return CdmResponseType(UNKNOWN_ERROR);
     }
-    *query_response = cdm_version;
+    *query_response = std::move(cdm_version);
     return CdmResponseType(NO_ERROR);
   }
   if (query_token == QUERY_KEY_RESOURCE_RATING_TIER) {
@@ -933,7 +935,7 @@ CdmResponseType CdmEngine::QueryStatus(RequestedSecurityLevel security_level,
     metrics_->GetCryptoMetrics()
         ->crypto_session_get_device_unique_id_.Increment(status);
     if (status != NO_ERROR) return status;
-    *query_response = device_id;
+    *query_response = std::move(device_id);
     return CdmResponseType(NO_ERROR);
   }
   if (query_token == QUERY_KEY_PROVISIONING_ID) {
@@ -943,7 +945,7 @@ CdmResponseType CdmEngine::QueryStatus(RequestedSecurityLevel security_level,
       LOGW("GetProvisioningId failed: status = %d", static_cast<int>(status));
       return status;
     }
-    *query_response = provisioning_id;
+    *query_response = std::move(provisioning_id);
     return CdmResponseType(NO_ERROR);
   }
   LOGW("Unknown status requested: query_token = %s", IdToString(query_token));

libwvdrmengine/cdm/core/src/cdm_session.cpp

@@ -70,7 +70,7 @@ int DrmKeyTypeToMetricValue(CryptoWrappedKey::Type type) {
 
 CdmSession::CdmSession(wvutil::FileSystem* file_system,
                        std::shared_ptr<metrics::SessionMetrics> metrics)
-    : metrics_(metrics),
+    : metrics_(std::move(metrics)),
       initialized_(false),
       closed_(true),
       file_handle_(new DeviceFiles(file_system)),

libwvdrmengine/cdm/core/src/policy_engine.cpp

@@ -30,7 +30,7 @@ namespace wvcdm {
 PolicyEngine::PolicyEngine(CdmSessionId session_id,
                            WvCdmEventListener* event_listener,
                            CryptoSession* crypto_session)
-    : session_id_(session_id),
+    : session_id_(std::move(session_id)),
       event_listener_(event_listener),
       license_keys_(new LicenseKeys(crypto_session->GetSecurityLevel())),
       clock_(new wvutil::Clock()) {