diff --git a/libwvdrmengine/cdm/core/src/certificate_provisioning.cpp b/libwvdrmengine/cdm/core/src/certificate_provisioning.cpp index 27e01b9f..048da402 100644 --- a/libwvdrmengine/cdm/core/src/certificate_provisioning.cpp +++ b/libwvdrmengine/cdm/core/src/certificate_provisioning.cpp @@ -318,9 +318,7 @@ CdmResponseType CertificateProvisioning::GetProvisioningRequestInternal( if (!wvcdm::Properties::provisioning_messages_are_binary()) { // Return request as web-safe base64 string - std::vector request_vector(serialized_request.begin(), - serialized_request.end()); - *request = Base64SafeEncodeNoPad(request_vector); + *request = Base64SafeEncodeNoPad(serialized_request); } else { *request = std::move(serialized_request); } diff --git a/libwvdrmengine/cdm/core/src/device_files.cpp b/libwvdrmengine/cdm/core/src/device_files.cpp index 2fa06fed..d21943c3 100644 --- a/libwvdrmengine/cdm/core/src/device_files.cpp +++ b/libwvdrmengine/cdm/core/src/device_files.cpp @@ -1771,9 +1771,7 @@ std::string DeviceFiles::GetUsageInfoFileName(const std::string& app_id) { } std::string DeviceFiles::GetFileNameSafeHash(const std::string& input) { - std::string hash = Md5Hash(input); - return wvcdm::Base64SafeEncode( - std::vector(hash.begin(), hash.end())); + return wvcdm::Base64SafeEncode(Md5Hash(input)); } } // namespace wvcdm diff --git a/libwvdrmengine/cdm/core/test/cdm_engine_test.cpp b/libwvdrmengine/cdm/core/test/cdm_engine_test.cpp index edcd8e8e..28d6dd78 100644 --- a/libwvdrmengine/cdm/core/test/cdm_engine_test.cpp +++ b/libwvdrmengine/cdm/core/test/cdm_engine_test.cpp @@ -107,9 +107,7 @@ class WvCdmEnginePreProvTest : public WvCdmTestBaseWithEngine { license_request.GetDrmMessage(http_response, *response); LOGV("response: size = %zu, string =\n%s\n", response->size(), - Base64SafeEncode( - std::vector(response->begin(), response->end())) - .c_str()); + Base64SafeEncode(*response).c_str()); return true; } diff --git a/libwvdrmengine/cdm/core/test/fake_provisioning_server.cpp b/libwvdrmengine/cdm/core/test/fake_provisioning_server.cpp index 1877f4bb..f6bdca48 100644 --- a/libwvdrmengine/cdm/core/test/fake_provisioning_server.cpp +++ b/libwvdrmengine/cdm/core/test/fake_provisioning_server.cpp @@ -352,11 +352,11 @@ bool FakeProvisioningServer::MakeResponse( // CDM. std::string response_data; signed_response.SerializeToString(&response_data); - std::vector response_data_v(response_data.begin(), - response_data.end()); - static const std::string json_start = "{ \"signedResponse\": \""; - static const std::string json_end = "\" }"; - *json_response = json_start + Base64SafeEncode(response_data_v) + json_end; + static const std::string kJsonStart = "{ \"signedResponse\": \""; + static const std::string kJsonEnd = "\" }"; + *json_response = kJsonStart; + json_response->append(Base64SafeEncode(response_data)); + json_response->append(kJsonEnd); return true; } diff --git a/libwvdrmengine/cdm/core/test/initialization_data_unittest.cpp b/libwvdrmengine/cdm/core/test/initialization_data_unittest.cpp index 717a00bc..692de725 100644 --- a/libwvdrmengine/cdm/core/test/initialization_data_unittest.cpp +++ b/libwvdrmengine/cdm/core/test/initialization_data_unittest.cpp @@ -341,11 +341,8 @@ class VectorOfStrings { std::string GenerateHlsUriData(const std::string& provider, const std::string& content_id, const std::vector& key_ids) { - std::string json = GenerateJsonInitData(provider, content_id, key_ids); - std::vector json_init_data( - reinterpret_cast(json.data()), - reinterpret_cast(json.data() + json.size())); - return kHlsTestUriDataFormat + Base64Encode(json_init_data); + const std::string json = GenerateJsonInitData(provider, content_id, key_ids); + return kHlsTestUriDataFormat + Base64Encode(json); } std::string CreateHlsAttributeList(const std::string& method, @@ -786,19 +783,16 @@ INSTANTIATE_TEST_CASE_P( .AddKeyId(kHlsTestKeyId1))); TEST_F(HlsInitDataConstructionTest, InvalidUriDataFormat) { - std::string json = + const std::string json = GenerateJsonInitData(kHlsTestProvider, kHlsTestContentId, VectorOfStrings(kHlsTestKeyId1).Generate()); - std::vector json_init_data( - reinterpret_cast(json.data()), - reinterpret_cast(json.data() + json.size())); std::string value; EXPECT_FALSE(InitializationData::ConstructWidevineInitData( - kHlsMethodAes128, Base64Encode(json_init_data), &value)); + kHlsMethodAes128, Base64Encode(json), &value)); } TEST_F(HlsInitDataConstructionTest, InvalidUriBase64Encode) { - std::string json = + const std::string json = GenerateJsonInitData(kHlsTestProvider, kHlsTestContentId, VectorOfStrings(kHlsTestKeyId1).Generate()); std::string value; diff --git a/libwvdrmengine/cdm/core/test/test_base.cpp b/libwvdrmengine/cdm/core/test/test_base.cpp index 3f4117f6..83e2d551 100644 --- a/libwvdrmengine/cdm/core/test/test_base.cpp +++ b/libwvdrmengine/cdm/core/test/test_base.cpp @@ -291,7 +291,6 @@ WvCdmTestBase::WvCdmTestBase() void WvCdmTestBase::Provision() { CdmProvisioningRequest prov_request; - CdmProvisioningRequest binary_prov_request; std::string provisioning_server_url; CdmCertificateType cert_type = kCertificateWidevine; std::string cert_authority; @@ -331,9 +330,7 @@ void WvCdmTestBase::Provision() { ASSERT_EQ(NO_ERROR, result); if (binary_provisioning_) { - binary_prov_request = prov_request; - prov_request = std::string(Base64SafeEncodeNoPad(std::vector( - binary_prov_request.begin(), binary_prov_request.end()))); + prov_request = Base64SafeEncodeNoPad(prov_request); } LOGV("Provisioning request: req = %s", prov_request.c_str()); diff --git a/libwvdrmengine/cdm/test/request_license_test.cpp b/libwvdrmengine/cdm/test/request_license_test.cpp index c0198cc6..e8dff3e5 100644 --- a/libwvdrmengine/cdm/test/request_license_test.cpp +++ b/libwvdrmengine/cdm/test/request_license_test.cpp @@ -8,6 +8,7 @@ #include #include #include +#include #include #include @@ -2613,9 +2614,9 @@ TEST_F(WvCdmRequestLicenseTest, ProvisioningRevocationTest) { signed_response.SerializeToString(&response); if (!wvcdm::Properties::provisioning_messages_are_binary()) { - std::vector response_vec(response.begin(), response.end()); + const std::string binary_response = std::move(response); response = "\"signedResponse\": \""; - response.append(wvcdm::Base64SafeEncode(response_vec)); + response.append(wvcdm::Base64SafeEncode(binary_response)); response.append("\""); } diff --git a/libwvdrmengine/mediadrm/test/WVDrmPlugin_test.cpp b/libwvdrmengine/mediadrm/test/WVDrmPlugin_test.cpp index a4be0776..16779b5a 100644 --- a/libwvdrmengine/mediadrm/test/WVDrmPlugin_test.cpp +++ b/libwvdrmengine/mediadrm/test/WVDrmPlugin_test.cpp @@ -3224,10 +3224,10 @@ TEST_F(WVDrmPluginTest, CanSetDecryptHashProperties) { // ",," static const std::string frameNumber = ",1"; uint32_t hash = 0xbeef; // crc32 hash - std::vector hashVector( + const std::vector hashVector( reinterpret_cast(&hash), reinterpret_cast(&hash) + sizeof(uint32_t)); - std::string base64EncodedHash = Base64Encode(hashVector); + const std::string base64EncodedHash = Base64Encode(hashVector); std::string computedHash(sessionId.begin(), sessionId.end()); computedHash.append(frameNumber.c_str()); computedHash.append(base64EncodedHash.c_str());