widevine-partner/android
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix oemcrypto-v19 issues identified by Coverity

Browse Source 
Change-Id: Idd79f02337640047979f5a41dd922d14c78c3b2e
This commit is contained in:
Ian Benz
2024-02-08 20:12:20 +00:00
committed by Robert Shih
parent 4638259a0c
commit 6d56eed754
3 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
libwvdrmengine/cdm/core/src/certificate_provisioning.cpp
View File

@@ -489,7 +489,7 @@ CdmResponseType CertificateProvisioning::GetProvisioning40RequestInternal(
} else {
*request = std::move(serialized_request);
}
request_ = serialized_message;
request_ = std::move(serialized_message);
return CdmResponseType(NO_ERROR);
}

2
libwvdrmengine/cdm/core/test/core_integration_test.cpp
View File

@@ -84,7 +84,7 @@ class CoreIntegrationTest : public WvCdmTestBaseWithEngine {
const std::string origin, std::string* spoid,
std::string* drm_certificate_serial_number) {
std::string name = app_package_name + origin;
return Provision(name, spoid, drm_certificate_serial_number);
return Provision(std::move(name), spoid, drm_certificate_serial_number);
}
private:

4
libwvdrmengine/oemcrypto/util/src/signed_csr_payload_validator.cpp
View File

@@ -131,7 +131,7 @@ CborMessageStatus SignedCsrPayloadValidator::ValidateProtectedParams(
"Unsupported signature algorithm value: " + std::to_string(algo));
return message_status_;
}
AddMessages(msg_ss_, {kv}, 1);
AddMessages(msg_ss_, {std::move(kv)}, 1);
algo_found = true;
}
}
@@ -196,7 +196,7 @@ CborMessageStatus SignedCsrPayloadValidator::ValidateDataToBeSigned(
std::to_string(challenge->value().size()) + " bytes long.");
}
msg += wvutil::b2a_hex(challenge->value());
AddMessages(msg_ss_, {msg}, 1);
AddMessages(msg_ss_, {std::move(msg)}, 1);
// Element 1: CsrPayload.
AddMessages(msg_ss_, {"- CsrPayload:"}, 1);