From 8aabf201344203bc608d53bb901fcef129dbb128 Mon Sep 17 00:00:00 2001 From: Alex Dale Date: Thu, 8 Jul 2021 18:23:54 -0700 Subject: [PATCH] Correctly record license service version in metrics. [ Cherry-pick of http://ag/15245767 ] [ Merge of http://go/wvgerrit/128624 ] The CDM session was incorrectly recording the "license SDK version" as the "license service version" in the session metrics. This discrepancy reduces the quality of devices' metrics and limits debugging capabilities for the Widevine metric monitoring services. Bug: 193177333 Test: Linux unit tests Change-Id: Ic58cf7bc4fde777bb590c05777b76f5ff5c2f1ea (cherry picked from commit 78278c3eb4da0097ddb1649ffdf242e8f3120579) --- libwvdrmengine/cdm/core/src/cdm_session.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libwvdrmengine/cdm/core/src/cdm_session.cpp b/libwvdrmengine/cdm/core/src/cdm_session.cpp index 4120117e..e9a07aef 100644 --- a/libwvdrmengine/cdm/core/src/cdm_session.cpp +++ b/libwvdrmengine/cdm/core/src/cdm_session.cpp @@ -557,7 +557,8 @@ CdmResponseType CdmSession::AddKeyInternal(const CdmKeyResponse& key_response) { // Update the license sdk and service versions. const VersionInfo& version_info = license_parser_->GetServiceVersion(); metrics_->license_sdk_version_.Record(version_info.license_sdk_version()); - metrics_->license_sdk_version_.Record(version_info.license_service_version()); + metrics_->license_service_version_.Record( + version_info.license_service_version()); // Update or invalidate entry if usage table header+entries are supported if (!provider_session_token.empty() && supports_usage_info()) {