From 8bf106f188a2eab8e85221effed32bdb5d10b137 Mon Sep 17 00:00:00 2001 From: Googler Date: Wed, 24 Jan 2024 22:44:49 -0800 Subject: [PATCH] Fix 1 AbslSpanParams finding: * This is a change required to migrate function parameters to absl::Span from const std::vector MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit See go/vector2span for more information on why you've received this change and why it is important. This CL looks good? Just LGTM and Approve it! This CL doesn’t look good? This is what you can do: * Revert this CL, by replying "REVERT: " * File a bug under go/absl-span-params-bug for category AbslSpanParams if there's an issue with the CL content. * File a bug under go/rosie-bug if there's an issue with how the CL was managed. * For all other issues such as the formatting of the CL, please file a bug under go/clrobot-bug. * Revert this CL and not get a CL that cleans up these paths in the future by replying "BLOCKLIST: ". This is not reversible! We recommend to opt out the respective paths in your CL Robot configuration instead: go/clrobot-opt-out. This CL was generated by CL Robot - a tool that cleans up code findings (go/clrobot). The affected code paths have been enabled for CL Robot in //depot/google3/METADATA by following go/clrobot#how-to-opt-in. Anything wrong with the signup? File a bug at go/clrobot-bug. #codehealth Tested: Local presubmit tests passed. PiperOrigin-RevId: 601343954 Change-Id: I1d138aee430e96915a238464ee3b2277ce9b6772 --- libwvdrmengine/oemcrypto/odk/include/odk_structs.h | 2 +- libwvdrmengine/oemcrypto/odk/test/odk_test.cpp | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/libwvdrmengine/oemcrypto/odk/include/odk_structs.h b/libwvdrmengine/oemcrypto/odk/include/odk_structs.h index 815af8a0..f4044bd5 100644 --- a/libwvdrmengine/oemcrypto/odk/include/odk_structs.h +++ b/libwvdrmengine/oemcrypto/odk/include/odk_structs.h @@ -19,7 +19,7 @@ extern "C" { #define ODK_MINOR_VERSION 0 /* ODK Version string. Date changed automatically on each release. */ -#define ODK_RELEASE_DATE "ODK v19.0 2024-01-09" +#define ODK_RELEASE_DATE "ODK v19.0 2024-01-25" /* The lowest version number for an ODK message. */ #define ODK_FIRST_VERSION 16 diff --git a/libwvdrmengine/oemcrypto/odk/test/odk_test.cpp b/libwvdrmengine/oemcrypto/odk/test/odk_test.cpp index 31caf251..cf2cd174 100644 --- a/libwvdrmengine/oemcrypto/odk/test/odk_test.cpp +++ b/libwvdrmengine/oemcrypto/odk/test/odk_test.cpp @@ -22,6 +22,7 @@ #include "odk_structs.h" #include "odk_structs_priv.h" #include "odk_test_helper.h" +#include "third_party/absl/types/span.h" namespace wvodk_test { @@ -112,7 +113,7 @@ bool CheckCounterInfoIsEqual(ODK_MessageCounterInfo* a, ODK_MessageCounter* b) { template void ValidateRequest(uint32_t message_type, - const std::vector& extra_fields, + absl::Span extra_fields, const F& odk_prepare_func, const G& kdo_parse_func) { uint32_t message_size = 0; uint16_t api_major_version = ODK_MAJOR_VERSION;