From 8e48e3655485a8314769c2bcd125c7231a5a92ae Mon Sep 17 00:00:00 2001 From: Ian Benz Date: Thu, 25 Jan 2024 14:26:58 +0000 Subject: [PATCH] Fix uninitialized variable in Provisioning40CastRoundTrip - Initialize allowed_schemes_ since it is used by CreateDefaultResponse. - Issue was detected by Coverity. Change-Id: I368c4773f6316b65196aaa39e23e70717299c570 --- libwvdrmengine/oemcrypto/test/oec_session_util.h | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/libwvdrmengine/oemcrypto/test/oec_session_util.h b/libwvdrmengine/oemcrypto/test/oec_session_util.h index 0bf13b0a..64af9f45 100644 --- a/libwvdrmengine/oemcrypto/test/oec_session_util.h +++ b/libwvdrmengine/oemcrypto/test/oec_session_util.h @@ -337,8 +337,8 @@ class Provisioning40RoundTrip // Not used. Use Load*CertResponse() below to load OEM/DRM response // respectively. - void CreateDefaultResponse() override{}; - void EncryptAndSignResponse() override{}; + void CreateDefaultResponse() override {}; + void EncryptAndSignResponse() override {}; OEMCryptoResult LoadResponse(Session* session) override { return OEMCrypto_ERROR_NOT_IMPLEMENTED; } @@ -382,8 +382,10 @@ class Provisioning40CastRoundTrip /* ResponseData */ RSAPrivateKeyMessage> { public: Provisioning40CastRoundTrip(Session* session, - const std::vector& encoded_rsa_key) - : RoundTrip(session), encryptor_(), + const std::vector& encoded_rsa_key) + : RoundTrip(session), + allowed_schemes_(kSign_RSASSA_PSS), + encryptor_(), encoded_rsa_key_(encoded_rsa_key) {} void PrepareSession(); @@ -393,7 +395,8 @@ class Provisioning40CastRoundTrip void EncryptAndSignResponse() override; OEMCryptoResult LoadResponse() override { return LoadResponse(session_); } OEMCryptoResult LoadResponse(Session* session) override; - OEMCryptoResult LoadResponseNoRetry(Session* session, size_t* wrapped_key_length) ; + OEMCryptoResult LoadResponseNoRetry(Session* session, + size_t* wrapped_key_length); // Returned const std::vector& wrapped_drm_key() { return wrapped_drm_key_; }