diff --git a/libwvdrmengine/cdm/core/include/cdm_engine.h b/libwvdrmengine/cdm/core/include/cdm_engine.h index d7ac3af0..56254216 100644 --- a/libwvdrmengine/cdm/core/include/cdm_engine.h +++ b/libwvdrmengine/cdm/core/include/cdm_engine.h @@ -19,7 +19,6 @@ #include "lock.h" #include "metrics_collections.h" #include "oemcrypto_adapter.h" -#include "scoped_ptr.h" #include "service_certificate.h" #include "wv_cdm_constants.h" #include "wv_cdm_types.h" @@ -325,7 +324,7 @@ class CdmEngine { CdmSessionMap session_map_; CdmReleaseKeySetMap release_key_sets_; - scoped_ptr cert_provisioning_; + std::unique_ptr cert_provisioning_; SecurityLevel cert_provisioning_requested_security_level_; FileSystem* file_system_; Clock clock_; @@ -334,8 +333,8 @@ class CdmEngine { static bool seeded_; // usage related variables - scoped_ptr usage_session_; - scoped_ptr usage_property_set_; + std::unique_ptr usage_session_; + std::unique_ptr usage_property_set_; int64_t last_usage_information_update_time_; // Protect release_key_sets_ from non-thread-safe operations. diff --git a/libwvdrmengine/cdm/core/include/cdm_session.h b/libwvdrmengine/cdm/core/include/cdm_session.h index 04e7ef74..8eaf949f 100644 --- a/libwvdrmengine/cdm/core/include/cdm_session.h +++ b/libwvdrmengine/cdm/core/include/cdm_session.h @@ -5,6 +5,7 @@ #ifndef WVCDM_CORE_CDM_SESSION_H_ #define WVCDM_CORE_CDM_SESSION_H_ +#include #include #include #include @@ -18,7 +19,6 @@ #include "metrics_collections.h" #include "oemcrypto_adapter.h" #include "policy_engine.h" -#include "scoped_ptr.h" #include "timer_metric.h" #include "wv_cdm_types.h" @@ -228,10 +228,10 @@ class CdmSession { bool closed_; // Session closed, but final shared_ptr has not been released. CdmSessionId session_id_; FileSystem* file_system_; - scoped_ptr license_parser_; - scoped_ptr crypto_session_; - scoped_ptr policy_engine_; - scoped_ptr file_handle_; + std::unique_ptr license_parser_; + std::unique_ptr crypto_session_; + std::unique_ptr policy_engine_; + std::unique_ptr file_handle_; bool license_received_; bool is_offline_; bool is_release_; diff --git a/libwvdrmengine/cdm/core/include/certificate_provisioning.h b/libwvdrmengine/cdm/core/include/certificate_provisioning.h index 1468f204..b0aeaef6 100644 --- a/libwvdrmengine/cdm/core/include/certificate_provisioning.h +++ b/libwvdrmengine/cdm/core/include/certificate_provisioning.h @@ -5,6 +5,7 @@ #ifndef WVCDM_CORE_CERTIFICATE_PROVISIONING_H_ #define WVCDM_CORE_CERTIFICATE_PROVISIONING_H_ +#include #include #include "crypto_session.h" @@ -12,7 +13,6 @@ #include "license_protocol.pb.h" #include "metrics_collections.h" #include "oemcrypto_adapter.h" -#include "scoped_ptr.h" #include "service_certificate.h" #include "wv_cdm_types.h" @@ -53,9 +53,9 @@ class CertificateProvisioning { video_widevine::SignedProvisioningMessage::ProtocolVersion GetProtocolVersion(); - scoped_ptr crypto_session_; + std::unique_ptr crypto_session_; CdmCertificateType cert_type_; - scoped_ptr service_certificate_; + std::unique_ptr service_certificate_; CORE_DISALLOW_COPY_AND_ASSIGN(CertificateProvisioning); }; diff --git a/libwvdrmengine/cdm/core/include/crypto_session.h b/libwvdrmengine/cdm/core/include/crypto_session.h index ed46c1c3..d421ba18 100644 --- a/libwvdrmengine/cdm/core/include/crypto_session.h +++ b/libwvdrmengine/cdm/core/include/crypto_session.h @@ -6,6 +6,7 @@ #define WVCDM_CORE_CRYPTO_SESSION_H_ #include +#include #include #include @@ -15,7 +16,6 @@ #include "lock.h" #include "metrics_collections.h" #include "oemcrypto_adapter.h" -#include "scoped_ptr.h" #include "timer_metric.h" #include "wv_cdm_types.h" @@ -295,7 +295,7 @@ class CryptoSession { SubLicenseSessionMap sub_license_oec_sessions_; // Used for sub license sessions. std::string wrapped_key_; - scoped_ptr key_session_; + std::unique_ptr key_session_; OEMCryptoBufferType destination_buffer_type_; bool is_destination_buffer_type_valid_; @@ -313,7 +313,7 @@ class CryptoSession { CdmCipherMode cipher_mode_; uint32_t api_version_; - static scoped_ptr factory_; + static std::unique_ptr factory_; CORE_DISALLOW_COPY_AND_ASSIGN(CryptoSession); }; diff --git a/libwvdrmengine/cdm/core/include/device_files.h b/libwvdrmengine/cdm/core/include/device_files.h index 82ceeb16..cf780d9c 100644 --- a/libwvdrmengine/cdm/core/include/device_files.h +++ b/libwvdrmengine/cdm/core/include/device_files.h @@ -13,7 +13,6 @@ #include "device_files.pb.h" #include "disallow_copy_and_assign.h" -#include "scoped_ptr.h" #include "wv_cdm_types.h" #if defined(UNIT_TEST) diff --git a/libwvdrmengine/cdm/core/include/license.h b/libwvdrmengine/cdm/core/include/license.h index 12d041d5..01cd5d10 100644 --- a/libwvdrmengine/cdm/core/include/license.h +++ b/libwvdrmengine/cdm/core/include/license.h @@ -5,12 +5,12 @@ #ifndef WVCDM_CORE_LICENSE_H_ #define WVCDM_CORE_LICENSE_H_ +#include #include #include "disallow_copy_and_assign.h" #include "initialization_data.h" #include "license_protocol.pb.h" -#include "scoped_ptr.h" #include "service_certificate.h" #include "wv_cdm_types.h" @@ -121,7 +121,7 @@ class CdmLicense { CdmClientTokenType client_token_type_; std::string device_id_; const CdmSessionId session_id_; - scoped_ptr stored_init_data_; + std::unique_ptr stored_init_data_; bool initialized_; std::set loaded_keys_; std::string provider_session_token_; @@ -135,7 +135,7 @@ class CdmLicense { // Used for certificate based licensing CdmKeyMessage key_request_; - scoped_ptr clock_; + std::unique_ptr clock_; // For testing // CdmLicense takes ownership of the clock. diff --git a/libwvdrmengine/cdm/core/include/policy_engine.h b/libwvdrmengine/cdm/core/include/policy_engine.h index 5511be05..48436fea 100644 --- a/libwvdrmengine/cdm/core/include/policy_engine.h +++ b/libwvdrmengine/cdm/core/include/policy_engine.h @@ -6,12 +6,12 @@ #define WVCDM_CORE_POLICY_ENGINE_H_ #include +#include #include #include "disallow_copy_and_assign.h" #include "license_key_status.h" #include "license_protocol.pb.h" -#include "scoped_ptr.h" #include "wv_cdm_types.h" namespace wvcdm { @@ -212,14 +212,14 @@ class PolicyEngine { // Keys associated with license - holds allowed usage, usage constraints, // and current status (CdmKeyStatus) - scoped_ptr license_keys_; + std::unique_ptr license_keys_; // Device checks int64_t next_device_check_; uint32_t current_resolution_; CryptoSession* crypto_session_; - scoped_ptr clock_; + std::unique_ptr clock_; CORE_DISALLOW_COPY_AND_ASSIGN(PolicyEngine); }; diff --git a/libwvdrmengine/cdm/core/include/properties.h b/libwvdrmengine/cdm/core/include/properties.h index d6777c4e..6efdf7a3 100644 --- a/libwvdrmengine/cdm/core/include/properties.h +++ b/libwvdrmengine/cdm/core/include/properties.h @@ -6,12 +6,12 @@ #define WVCDM_CORE_PROPERTIES_H_ #include +#include #include #include "cdm_client_property_set.h" #include "disallow_copy_and_assign.h" #include "lock.h" -#include "scoped_ptr.h" #include "wv_cdm_types.h" #if defined(UNIT_TEST) @@ -115,7 +115,7 @@ class Properties { static bool use_certificates_as_identification_; static bool provisioning_messages_are_binary_; static bool allow_service_certificate_requests_; - static scoped_ptr session_property_set_; + static std::unique_ptr session_property_set_; CORE_DISALLOW_COPY_AND_ASSIGN(Properties); }; diff --git a/libwvdrmengine/cdm/core/include/scoped_ptr.h b/libwvdrmengine/cdm/core/include/scoped_ptr.h deleted file mode 100644 index cfff35f8..00000000 --- a/libwvdrmengine/cdm/core/include/scoped_ptr.h +++ /dev/null @@ -1,67 +0,0 @@ -// Copyright 2018 Google LLC. All Rights Reserved. This file and proprietary -// source code may only be used and distributed under the Widevine Master -// License Agreement. -// -// A simple and partial implementation of scoped_ptr class. -// The implementation is copied from gtest/include/gtest/internal/gtest-port.h. -// -#ifndef WVCDM_CORE_SCOPED_PTR_H_ -#define WVCDM_CORE_SCOPED_PTR_H_ - -#include "disallow_copy_and_assign.h" - -namespace wvcdm { - -// A scoped_ptr is like a T*, except that the destructor of scoped_ptr -// automatically deletes the pointer it holds (if any). -// That is, scoped_ptr owns the T object that it points to. -// Like a T*, a scoped_ptr may hold either NULL or a pointer to a T object. -// Also like T*, scoped_ptr is thread-compatible, and once you -// dereference it, you get the thread safety guarantees of T. -// -// The size of scoped_ptr is small. On most compilers, sizeof(scoped_ptr) -// == sizeof(T*). -// -// Current implementation targets having a strict subset of C++11's -// unique_ptr<> features. Known deficiencies include not supporting move-only -// deleteres, function pointers as deleters, and deleters with reference -// types. - -// This implementation of scoped_ptr is PARTIAL, e.g. it does not support move, -// custom deleter etc. -template -class scoped_ptr { - public: - typedef T element_type; - - explicit scoped_ptr(T* p = NULL) : ptr_(p) {} - ~scoped_ptr() { reset(); } - - T& operator*() const { return *ptr_; } - T* operator->() const { return ptr_; } - T* get() const { return ptr_; } - - T* release() { - T* const ptr = ptr_; - ptr_ = NULL; - return ptr; - } - - void reset(T* p = NULL) { - if (p != ptr_) { - if (sizeof(T) > 0) { // Makes sure T is a complete type. - delete ptr_; - } - ptr_ = p; - } - } - - private: - T* ptr_; - - CORE_DISALLOW_COPY_AND_ASSIGN(scoped_ptr); -}; - -} // namespace wvcdm - -#endif // WVCDM_CORE_SCOPED_PTR_H_ diff --git a/libwvdrmengine/cdm/core/include/service_certificate.h b/libwvdrmengine/cdm/core/include/service_certificate.h index a76c95f8..b11ee3d1 100644 --- a/libwvdrmengine/cdm/core/include/service_certificate.h +++ b/libwvdrmengine/cdm/core/include/service_certificate.h @@ -18,7 +18,6 @@ #include "disallow_copy_and_assign.h" #include "license_protocol.pb.h" #include "privacy_crypto.h" -#include "scoped_ptr.h" #include "wv_cdm_types.h" namespace wvcdm { @@ -79,7 +78,7 @@ class ServiceCertificate { std::string provider_id_; // Public key. - scoped_ptr public_key_; + std::unique_ptr public_key_; CORE_DISALLOW_COPY_AND_ASSIGN(ServiceCertificate); }; diff --git a/libwvdrmengine/cdm/core/include/usage_table_header.h b/libwvdrmengine/cdm/core/include/usage_table_header.h index 6b3ca861..7bf6456c 100644 --- a/libwvdrmengine/cdm/core/include/usage_table_header.h +++ b/libwvdrmengine/cdm/core/include/usage_table_header.h @@ -5,6 +5,7 @@ #ifndef WVCDM_CORE_USAGE_TABLE_HEADER_H_ #define WVCDM_CORE_USAGE_TABLE_HEADER_H_ +#include #include #include @@ -14,7 +15,6 @@ #include "file_store.h" #include "lock.h" #include "metrics_collections.h" -#include "scoped_ptr.h" #include "wv_cdm_types.h" namespace wvcdm { @@ -100,8 +100,8 @@ class UsageTableHeader { // This handle and file system is only to be used when accessing // usage_table_header. Usage entries should use the file system provided // by CdmSession. - scoped_ptr file_handle_; - scoped_ptr file_system_; + std::unique_ptr file_handle_; + std::unique_ptr file_system_; CdmSecurityLevel security_level_; SecurityLevel requested_security_level_; @@ -131,7 +131,7 @@ class UsageTableHeader { } // Test related data members - scoped_ptr test_crypto_session_; + std::unique_ptr test_crypto_session_; CORE_DISALLOW_COPY_AND_ASSIGN(UsageTableHeader); }; diff --git a/libwvdrmengine/cdm/core/src/cdm_engine.cpp b/libwvdrmengine/cdm/core/src/cdm_engine.cpp index 5dd0e106..6cb92813 100644 --- a/libwvdrmengine/cdm/core/src/cdm_engine.cpp +++ b/libwvdrmengine/cdm/core/src/cdm_engine.cpp @@ -60,11 +60,12 @@ class UsagePropertySet : public CdmClientPropertySet { bool CdmEngine::seeded_ = false; CdmEngine::CdmEngine(FileSystem* file_system, const std::string& spoid) - : cert_provisioning_(NULL), + : cert_provisioning_(), cert_provisioning_requested_security_level_(kLevelDefault), file_system_(file_system), spoid_(spoid), - usage_session_(NULL), + usage_session_(), + usage_property_set_(), last_usage_information_update_time_(0) { assert(file_system); if (!seeded_) { @@ -126,7 +127,7 @@ CdmResponseType CdmEngine::OpenSession( CloseExpiredReleaseSessions(); - scoped_ptr new_session(new CdmSession(file_system_, + std::unique_ptr new_session(new CdmSession(file_system_, metrics_.AddSession())); CdmResponseType sts = new_session->Init(property_set, forced_session_id, event_listener); @@ -491,7 +492,7 @@ CdmResponseType CdmEngine::QueryStatus(SecurityLevel security_level, const std::string& query_token, std::string* query_response) { LOGI("CdmEngine::QueryStatus"); - scoped_ptr crypto_session( + std::unique_ptr crypto_session( CryptoSession::MakeCryptoSession(metrics_.GetCryptoMetrics())); CdmResponseType status; M_TIME( @@ -833,7 +834,7 @@ CdmResponseType CdmEngine::HandleProvisioningResponse( if (NULL == cert_provisioning_.get()) { // Certificate provisioning object has been released. Check if a concurrent // provisioning attempt has succeeded before declaring failure. - scoped_ptr crypto_session( + std::unique_ptr crypto_session( CryptoSession::MakeCryptoSession(metrics_.GetCryptoMetrics())); CdmResponseType status; M_TIME( @@ -889,7 +890,7 @@ bool CdmEngine::IsProvisioned(CdmSecurityLevel security_level) { CdmResponseType CdmEngine::Unprovision(CdmSecurityLevel security_level) { // Devices with baked-in DRM certs cannot be reprovisioned and therefore must // not be unprovisioned. - scoped_ptr crypto_session( + std::unique_ptr crypto_session( CryptoSession::MakeCryptoSession(metrics_.GetCryptoMetrics())); CdmClientTokenType token_type = kClientTokenUninitialized; CdmResponseType res = crypto_session->GetProvisioningMethod( @@ -923,7 +924,7 @@ CdmResponseType CdmEngine::Unprovision(CdmSecurityLevel security_level) { } CdmResponseType CdmEngine::DeleteUsageTable(CdmSecurityLevel security_level) { - scoped_ptr crypto_session( + std::unique_ptr crypto_session( CryptoSession::MakeCryptoSession(metrics_.GetCryptoMetrics())); CdmResponseType status; M_TIME( @@ -1006,7 +1007,7 @@ CdmResponseType CdmEngine::DeleteUsageRecord(const std::string& app_id, } // Got provider token. Remove from OEMCrypto. - scoped_ptr crypto_session( + std::unique_ptr crypto_session( CryptoSession::MakeCryptoSession(metrics_.GetCryptoMetrics())); CdmResponseType status = crypto_session->Open( security_level == kSecurityLevelL3 ? kLevel3 : kLevelDefault); @@ -1215,7 +1216,7 @@ CdmResponseType CdmEngine::RemoveAllUsageInfo( } // Got at least one provider token. Remove from OEMCrypto. - scoped_ptr crypto_session( + std::unique_ptr crypto_session( CryptoSession::MakeCryptoSession(metrics_.GetCryptoMetrics())); CdmResponseType status = crypto_session->Open( security_level == kSecurityLevelL3 ? kLevel3 : kLevelDefault); @@ -1369,7 +1370,7 @@ CdmResponseType CdmEngine::RemoveUsageInfo( handle.DeleteUsageInfo( DeviceFiles::GetUsageInfoFileName(app_id), provider_session_token); - scoped_ptr crypto_session( + std::unique_ptr crypto_session( CryptoSession::MakeCryptoSession(metrics_.GetCryptoMetrics())); status = crypto_session->Open( static_cast(j) == kSecurityLevelL3 @@ -1807,7 +1808,7 @@ void CdmEngine::DeleteAllUsageReportsUponFactoryReset() { if (!file_system_->Exists(device_base_path_level1) && !file_system_->Exists(device_base_path_level3)) { - scoped_ptr crypto_session( + std::unique_ptr crypto_session( CryptoSession::MakeCryptoSession(metrics_.GetCryptoMetrics())); CdmResponseType status; M_TIME( diff --git a/libwvdrmengine/cdm/core/src/crypto_session.cpp b/libwvdrmengine/cdm/core/src/crypto_session.cpp index 42d09941..b43bfc7b 100644 --- a/libwvdrmengine/cdm/core/src/crypto_session.cpp +++ b/libwvdrmengine/cdm/core/src/crypto_session.cpp @@ -2577,7 +2577,8 @@ void CryptoSession::IncrementIV(uint64_t increase_by, // The factory will either be set by WvCdmTestBase, or a default factory is // created on the first call to MakeCryptoSession. -scoped_ptr CryptoSession::factory_(NULL); +std::unique_ptr CryptoSession::factory_ = + std::unique_ptr(); CryptoSession* CryptoSession::MakeCryptoSession( metrics::CryptoMetrics* crypto_metrics) { diff --git a/libwvdrmengine/cdm/core/src/oemcrypto_adapter_dynamic.cpp b/libwvdrmengine/cdm/core/src/oemcrypto_adapter_dynamic.cpp index 5df23f45..f5c5f3ab 100644 --- a/libwvdrmengine/cdm/core/src/oemcrypto_adapter_dynamic.cpp +++ b/libwvdrmengine/cdm/core/src/oemcrypto_adapter_dynamic.cpp @@ -20,6 +20,7 @@ #include #include +#include #include #include "file_store.h" @@ -28,7 +29,6 @@ #include "log.h" #include "metrics_collections.h" #include "properties.h" -#include "scoped_ptr.h" #include "wv_cdm_constants.h" using namespace wvoec3; @@ -938,7 +938,7 @@ class Adapter { } }; -static wvcdm::scoped_ptr gAdapter; +static std::unique_ptr gAdapter; } // namespace namespace wvcdm { diff --git a/libwvdrmengine/cdm/core/src/properties.cpp b/libwvdrmengine/cdm/core/src/properties.cpp index 94da7ab2..84778df9 100644 --- a/libwvdrmengine/cdm/core/src/properties.cpp +++ b/libwvdrmengine/cdm/core/src/properties.cpp @@ -16,7 +16,7 @@ bool Properties::oem_crypto_use_fifo_; bool Properties::oem_crypto_use_userspace_buffers_; bool Properties::provisioning_messages_are_binary_; bool Properties::allow_service_certificate_requests_; -scoped_ptr Properties::session_property_set_; +std::unique_ptr Properties::session_property_set_; bool Properties::AddSessionPropertySet( const CdmSessionId& session_id, CdmClientPropertySet* property_set) { diff --git a/libwvdrmengine/cdm/core/src/usage_table_header.cpp b/libwvdrmengine/cdm/core/src/usage_table_header.cpp index cb463ed0..73158814 100644 --- a/libwvdrmengine/cdm/core/src/usage_table_header.cpp +++ b/libwvdrmengine/cdm/core/src/usage_table_header.cpp @@ -282,7 +282,7 @@ CdmResponseType UsageTableHeader::MoveEntry( // crypto_session points to an object whose scope is this method or a test // object whose scope is the lifetime of this class - scoped_ptr scoped_crypto_session; + std::unique_ptr scoped_crypto_session; CryptoSession* crypto_session = test_crypto_session_.get(); if (crypto_session == NULL) { scoped_crypto_session.reset((CryptoSession::MakeCryptoSession(metrics))); @@ -476,7 +476,7 @@ CdmResponseType UsageTableHeader::Shrink( // crypto_session points to an object whose scope is this method or a test // object whose scope is the lifetime of this class - scoped_ptr scoped_crypto_session; + std::unique_ptr scoped_crypto_session; CryptoSession* crypto_session = test_crypto_session_.get(); if (crypto_session == NULL) { scoped_crypto_session.reset((CryptoSession::MakeCryptoSession(metrics))); @@ -549,7 +549,7 @@ bool UsageTableHeader::UpgradeLicensesFromUsageTable( if (provider_session_token.empty()) continue; - scoped_ptr crypto_session( + std::unique_ptr crypto_session( CryptoSession::MakeCryptoSession(metrics)); CdmResponseType status = crypto_session->Open(requested_security_level_); @@ -632,7 +632,7 @@ bool UsageTableHeader::UpgradeUsageInfoFromUsageTable( continue; } - scoped_ptr crypto_session( + std::unique_ptr crypto_session( CryptoSession::MakeCryptoSession(metrics)); CdmResponseType status = crypto_session->Open(requested_security_level_); diff --git a/libwvdrmengine/cdm/core/test/cdm_engine_test.cpp b/libwvdrmengine/cdm/core/test/cdm_engine_test.cpp index 6428ad3c..58c0ae67 100644 --- a/libwvdrmengine/cdm/core/test/cdm_engine_test.cpp +++ b/libwvdrmengine/cdm/core/test/cdm_engine_test.cpp @@ -21,7 +21,6 @@ #include "metrics.pb.h" #include "OEMCryptoCENC.h" #include "properties.h" -#include "scoped_ptr.h" #include "string_conversions.h" #include "test_base.h" #include "test_printers.h" diff --git a/libwvdrmengine/cdm/core/test/cdm_session_unittest.cpp b/libwvdrmengine/cdm/core/test/cdm_session_unittest.cpp index dc62ce21..d5df0451 100644 --- a/libwvdrmengine/cdm/core/test/cdm_session_unittest.cpp +++ b/libwvdrmengine/cdm/core/test/cdm_session_unittest.cpp @@ -2,13 +2,15 @@ // source code may only be used and distributed under the Widevine Master // License Agreement. +#include + #include #include + #include "cdm_session.h" #include "crypto_key.h" #include "metrics.pb.h" #include "properties.h" -#include "scoped_ptr.h" #include "service_certificate.h" #include "string_conversions.h" #include "test_base.h" @@ -191,7 +193,7 @@ class CdmSessionTest : public WvCdmTestBase { } metrics::SessionMetrics metrics_; - scoped_ptr cdm_session_; + std::unique_ptr cdm_session_; MockCdmLicense* license_parser_; metrics::CryptoMetrics crypto_metrics_; NiceMock* crypto_session_; diff --git a/libwvdrmengine/cdm/core/test/crypto_session_unittest.cpp b/libwvdrmengine/cdm/core/test/crypto_session_unittest.cpp index 8666259c..c7262c33 100644 --- a/libwvdrmengine/cdm/core/test/crypto_session_unittest.cpp +++ b/libwvdrmengine/cdm/core/test/crypto_session_unittest.cpp @@ -3,6 +3,7 @@ // License Agreement. #include +#include #include #include @@ -14,7 +15,6 @@ #include "log.h" #include "metrics.pb.h" #include "metrics_collections.h" -#include "scoped_ptr.h" #include "test_base.h" #include "test_printers.h" #include "wv_cdm_types.h" @@ -282,7 +282,7 @@ class CryptoSessionMetricsTest : public WvCdmTestBase { TEST_F(CryptoSessionMetricsTest, OpenSessionValidMetrics) { metrics::CryptoMetrics crypto_metrics; - scoped_ptr session( + std::unique_ptr session( CryptoSession::MakeCryptoSession(&crypto_metrics)); session->Open(wvcdm::kLevelDefault); // Exercise a method that will touch a metric. @@ -340,7 +340,7 @@ TEST_F(CryptoSessionMetricsTest, OpenSessionValidMetrics) { TEST_F(CryptoSessionMetricsTest, GetProvisioningTokenValidMetrics) { metrics::CryptoMetrics crypto_metrics; - scoped_ptr session( + std::unique_ptr session( CryptoSession::MakeCryptoSession(&crypto_metrics)); ASSERT_EQ(NO_ERROR, session->Open(wvcdm::kLevelDefault)); diff --git a/libwvdrmengine/cdm/core/test/generic_crypto_unittest.cpp b/libwvdrmengine/cdm/core/test/generic_crypto_unittest.cpp index e3bd7050..b04a9ea8 100644 --- a/libwvdrmengine/cdm/core/test/generic_crypto_unittest.cpp +++ b/libwvdrmengine/cdm/core/test/generic_crypto_unittest.cpp @@ -20,7 +20,6 @@ #include "oemcrypto_session_tests_helper.h" #include "oemcrypto_types.h" #include "properties.h" -#include "scoped_ptr.h" #include "string_conversions.h" #include "test_base.h" #include "test_printers.h" diff --git a/libwvdrmengine/cdm/core/test/http_socket_test.cpp b/libwvdrmengine/cdm/core/test/http_socket_test.cpp index 4e631d32..d089dcbc 100644 --- a/libwvdrmengine/cdm/core/test/http_socket_test.cpp +++ b/libwvdrmengine/cdm/core/test/http_socket_test.cpp @@ -3,10 +3,12 @@ // License Agreement. #include +#include + #include + #include "http_socket.h" #include "log.h" -#include "scoped_ptr.h" #include "string_conversions.h" #include "url_request.h" @@ -90,7 +92,7 @@ class HttpSocketTest : public testing::Test { return true; } - scoped_ptr socket_; + std::unique_ptr socket_; std::string domain_name_; std::string resource_path_; }; diff --git a/libwvdrmengine/cdm/core/test/policy_engine_constraints_unittest.cpp b/libwvdrmengine/cdm/core/test/policy_engine_constraints_unittest.cpp index b1eb7719..141c6522 100644 --- a/libwvdrmengine/cdm/core/test/policy_engine_constraints_unittest.cpp +++ b/libwvdrmengine/cdm/core/test/policy_engine_constraints_unittest.cpp @@ -2,6 +2,8 @@ // source code may only be used and distributed under the Widevine Master // License Agreement. +#include + #include #include @@ -10,7 +12,6 @@ #include "metrics_collections.h" #include "policy_engine.h" #include "mock_clock.h" -#include "scoped_ptr.h" #include "test_base.h" #include "test_printers.h" #include "wv_cdm_event_listener.h" @@ -215,7 +216,7 @@ class PolicyEngineConstraintsTest : public WvCdmTestBase { expected_has_new_usable_key)); } - scoped_ptr policy_engine_; + std::unique_ptr policy_engine_; MockClock* mock_clock_; int64_t current_time_; metrics::CryptoMetrics dummy_metrics_; diff --git a/libwvdrmengine/cdm/core/test/policy_engine_unittest.cpp b/libwvdrmengine/cdm/core/test/policy_engine_unittest.cpp index da2dd59a..364e8480 100644 --- a/libwvdrmengine/cdm/core/test/policy_engine_unittest.cpp +++ b/libwvdrmengine/cdm/core/test/policy_engine_unittest.cpp @@ -5,6 +5,7 @@ #include #include +#include #include #include @@ -13,7 +14,6 @@ #include "license.h" #include "mock_clock.h" #include "policy_engine.h" -#include "scoped_ptr.h" #include "test_base.h" #include "test_printers.h" #include "wv_cdm_event_listener.h" @@ -185,7 +185,7 @@ class PolicyEngineTest : public WvCdmTestBase { NiceMock crypto_session_; StrictMock mock_event_listener_; MockClock* mock_clock_; - scoped_ptr policy_engine_; + std::unique_ptr policy_engine_; License license_; MockFunction check_; }; diff --git a/libwvdrmengine/cdm/metrics/test/counter_metric_unittest.cpp b/libwvdrmengine/cdm/metrics/test/counter_metric_unittest.cpp index b728391a..ea760eb1 100644 --- a/libwvdrmengine/cdm/metrics/test/counter_metric_unittest.cpp +++ b/libwvdrmengine/cdm/metrics/test/counter_metric_unittest.cpp @@ -6,7 +6,6 @@ #include "gmock/gmock.h" #include "gtest/gtest.h" -#include "scoped_ptr.h" #include "string_conversions.h" using drm_metrics::TestMetrics; diff --git a/libwvdrmengine/cdm/metrics/test/event_metric_unittest.cpp b/libwvdrmengine/cdm/metrics/test/event_metric_unittest.cpp index 09e6c889..8441e4c3 100644 --- a/libwvdrmengine/cdm/metrics/test/event_metric_unittest.cpp +++ b/libwvdrmengine/cdm/metrics/test/event_metric_unittest.cpp @@ -6,7 +6,6 @@ #include "gmock/gmock.h" #include "gtest/gtest.h" -#include "scoped_ptr.h" #include "string_conversions.h" using drm_metrics::TestMetrics; diff --git a/libwvdrmengine/cdm/metrics/test/value_metric_unittest.cpp b/libwvdrmengine/cdm/metrics/test/value_metric_unittest.cpp index 7c0e53a2..a6ec6c75 100644 --- a/libwvdrmengine/cdm/metrics/test/value_metric_unittest.cpp +++ b/libwvdrmengine/cdm/metrics/test/value_metric_unittest.cpp @@ -2,6 +2,7 @@ // // Unit tests for ValueMetric. +#include #include #include "value_metric.h" @@ -9,7 +10,6 @@ #include "gmock/gmock.h" #include "gtest/gtest.h" #include "metrics.pb.h" -#include "scoped_ptr.h" namespace wvcdm { namespace metrics { @@ -18,7 +18,7 @@ TEST(ValueMetricTest, StringValue) { ValueMetric metric; metric.Record("foo"); - wvcdm::scoped_ptr metric_proto(metric.ToProto()); + std::unique_ptr metric_proto(metric.ToProto()); ASSERT_EQ("foo", metric_proto->string_value()); ASSERT_FALSE(metric_proto->has_error_code()); } @@ -27,7 +27,7 @@ TEST(ValueMetricTest, DoubleValue) { ValueMetric metric; metric.Record(42.0); - wvcdm::scoped_ptr metric_proto(metric.ToProto()); + std::unique_ptr metric_proto(metric.ToProto()); ASSERT_EQ(42.0, metric_proto->double_value()); ASSERT_FALSE(metric_proto->has_error_code()); } @@ -36,7 +36,7 @@ TEST(ValueMetricTest, Int32Value) { ValueMetric metric; metric.Record(42); - wvcdm::scoped_ptr metric_proto(metric.ToProto()); + std::unique_ptr metric_proto(metric.ToProto()); ASSERT_EQ(42, metric_proto->int_value()); ASSERT_FALSE(metric_proto->has_error_code()); } @@ -45,7 +45,7 @@ TEST(ValueMetricTest, Int64Value) { ValueMetric metric; metric.Record(42); - wvcdm::scoped_ptr metric_proto(metric.ToProto()); + std::unique_ptr metric_proto(metric.ToProto()); ASSERT_EQ(42, metric_proto->int_value()); ASSERT_FALSE(metric_proto->has_error_code()); } @@ -55,7 +55,7 @@ TEST(ValueMetricTest, SetError) { metric.Record(42); metric.SetError(7); - wvcdm::scoped_ptr metric_proto(metric.ToProto()); + std::unique_ptr metric_proto(metric.ToProto()); ASSERT_EQ(7, metric_proto->error_code()); ASSERT_FALSE(metric_proto->has_int_value()); } diff --git a/libwvdrmengine/oemcrypto/ref/src/oemcrypto_auth_ref.h b/libwvdrmengine/oemcrypto/ref/src/oemcrypto_auth_ref.h index 6bdeb84c..61b85aaa 100644 --- a/libwvdrmengine/oemcrypto/ref/src/oemcrypto_auth_ref.h +++ b/libwvdrmengine/oemcrypto/ref/src/oemcrypto_auth_ref.h @@ -8,6 +8,7 @@ #define OEMCRYPTO_AUTH_REF_H_ #include +#include #include #include @@ -17,7 +18,6 @@ #include "oemcrypto_key_ref.h" #include "oemcrypto_keybox_ref.h" #include "oemcrypto_rsa_key_shared.h" -#include "oemcrypto_scoped_ptr.h" #include "oemcrypto_types.h" namespace wvoec_ref { diff --git a/libwvdrmengine/oemcrypto/ref/src/oemcrypto_engine_device_properties.cpp b/libwvdrmengine/oemcrypto/ref/src/oemcrypto_engine_device_properties.cpp index 20d8f026..a3bdf4e3 100644 --- a/libwvdrmengine/oemcrypto/ref/src/oemcrypto_engine_device_properties.cpp +++ b/libwvdrmengine/oemcrypto/ref/src/oemcrypto_engine_device_properties.cpp @@ -7,11 +7,13 @@ #include "oemcrypto_engine_ref.h" +#include + namespace wvoec_ref { CryptoEngine* CryptoEngine::MakeCryptoEngine( - scoped_ptr file_system) { - return new CryptoEngine(file_system); + std::unique_ptr&& file_system) { + return new CryptoEngine(std::move(file_system)); } } // namespace wvoec_ref diff --git a/libwvdrmengine/oemcrypto/ref/src/oemcrypto_engine_device_properties_L1.cpp b/libwvdrmengine/oemcrypto/ref/src/oemcrypto_engine_device_properties_L1.cpp index 749e2e66..5e92a88a 100644 --- a/libwvdrmengine/oemcrypto/ref/src/oemcrypto_engine_device_properties_L1.cpp +++ b/libwvdrmengine/oemcrypto/ref/src/oemcrypto_engine_device_properties_L1.cpp @@ -8,12 +8,14 @@ // level 1 device. #include "oemcrypto_engine_ref.h" +#include + namespace wvoec_ref { class L1CryptoEngine : public CryptoEngine { public: - explicit L1CryptoEngine(scoped_ptr file_system) - : CryptoEngine(file_system) {} + explicit L1CryptoEngine(std::unique_ptr&& file_system) + : CryptoEngine(std::move(file_system)) {} bool config_local_display_only() { return true; } @@ -31,8 +33,8 @@ class L1CryptoEngine : public CryptoEngine { }; CryptoEngine* CryptoEngine::MakeCryptoEngine( - scoped_ptr file_system) { - return new L1CryptoEngine(file_system); + std::unique_ptr&& file_system) { + return new L1CryptoEngine(std::move(file_system)); } } // namespace wvoec_ref diff --git a/libwvdrmengine/oemcrypto/ref/src/oemcrypto_engine_device_properties_cert.cpp b/libwvdrmengine/oemcrypto/ref/src/oemcrypto_engine_device_properties_cert.cpp index 73809f5d..df17c885 100644 --- a/libwvdrmengine/oemcrypto/ref/src/oemcrypto_engine_device_properties_cert.cpp +++ b/libwvdrmengine/oemcrypto/ref/src/oemcrypto_engine_device_properties_cert.cpp @@ -15,7 +15,7 @@ namespace wvoec_ref { class CertOnlyCryptoEngine : public CryptoEngine { public: - explicit CertOnlyCryptoEngine(scoped_ptr file_system) + explicit CertOnlyCryptoEngine(std::unique_ptr file_system) : CryptoEngine(file_system) {} bool config_local_display_only() { return true; } @@ -30,7 +30,7 @@ class CertOnlyCryptoEngine : public CryptoEngine { }; CryptoEngine* CryptoEngine::MakeCryptoEngine( - scoped_ptr file_system) { + std::unique_ptr file_system) { return new CertOnlyCryptoEngine(file_system); } diff --git a/libwvdrmengine/oemcrypto/ref/src/oemcrypto_engine_device_properties_prov30.cpp b/libwvdrmengine/oemcrypto/ref/src/oemcrypto_engine_device_properties_prov30.cpp index dacd9793..fe78fe61 100644 --- a/libwvdrmengine/oemcrypto/ref/src/oemcrypto_engine_device_properties_prov30.cpp +++ b/libwvdrmengine/oemcrypto/ref/src/oemcrypto_engine_device_properties_prov30.cpp @@ -12,6 +12,8 @@ #include +#include + #include "log.h" #include "oem_cert.h" @@ -19,8 +21,8 @@ namespace wvoec_ref { class Prov30CryptoEngine : public CryptoEngine { public: - explicit Prov30CryptoEngine(scoped_ptr file_system) - : CryptoEngine(file_system) {} + explicit Prov30CryptoEngine(std::unique_ptr&& file_system) + : CryptoEngine(std::move(file_system)) {} bool config_local_display_only() { return true; } @@ -77,8 +79,8 @@ class Prov30CryptoEngine : public CryptoEngine { }; CryptoEngine* CryptoEngine::MakeCryptoEngine( - scoped_ptr file_system) { - return new Prov30CryptoEngine(file_system); + std::unique_ptr&& file_system) { + return new Prov30CryptoEngine(std::move(file_system)); } } // namespace wvoec_ref diff --git a/libwvdrmengine/oemcrypto/ref/src/oemcrypto_engine_ref.cpp b/libwvdrmengine/oemcrypto/ref/src/oemcrypto_engine_ref.cpp index 4f225db8..5606883a 100644 --- a/libwvdrmengine/oemcrypto/ref/src/oemcrypto_engine_ref.cpp +++ b/libwvdrmengine/oemcrypto/ref/src/oemcrypto_engine_ref.cpp @@ -11,6 +11,7 @@ #include #include #include +#include #include #include @@ -27,10 +28,10 @@ namespace wvoec_ref { // all configurations. See the files oemcrypto_engine_device_properties*.cpp // for methods that are configured for specific configurations. -CryptoEngine::CryptoEngine(scoped_ptr file_system) +CryptoEngine::CryptoEngine(std::unique_ptr&& file_system) : root_of_trust_(config_provisioning_method()), - file_system_(file_system), - usage_table_(NULL) { + file_system_(std::move(file_system)), + usage_table_() { ERR_load_crypto_strings(); } diff --git a/libwvdrmengine/oemcrypto/ref/src/oemcrypto_engine_ref.h b/libwvdrmengine/oemcrypto/ref/src/oemcrypto_engine_ref.h index 60c9d096..58f443be 100644 --- a/libwvdrmengine/oemcrypto/ref/src/oemcrypto_engine_ref.h +++ b/libwvdrmengine/oemcrypto/ref/src/oemcrypto_engine_ref.h @@ -21,7 +21,6 @@ #include "oemcrypto_auth_ref.h" #include "oemcrypto_key_ref.h" #include "oemcrypto_rsa_key_shared.h" -#include "oemcrypto_scoped_ptr.h" #include "oemcrypto_session.h" #include "oemcrypto_usage_table_ref.h" #include "oemcrypto_types.h" @@ -38,7 +37,7 @@ class CryptoEngine { // NOTE: The caller must instantiate a FileSystem object - ownership // will be transferred to the new CryptoEngine object. static CryptoEngine* MakeCryptoEngine( - scoped_ptr file_system); + std::unique_ptr&& file_system); virtual ~CryptoEngine(); @@ -189,15 +188,15 @@ class CryptoEngine { } protected: - explicit CryptoEngine(scoped_ptr file_system); + explicit CryptoEngine(std::unique_ptr&& file_system); virtual SessionContext* MakeSession(SessionId sid); virtual UsageTable* MakeUsageTable(); uint8_t* destination_; ActiveSessions sessions_; AuthenticationRoot root_of_trust_; wvcdm::Lock session_table_lock_; - scoped_ptr file_system_; - scoped_ptr usage_table_; + std::unique_ptr file_system_; + std::unique_ptr usage_table_; CORE_DISALLOW_COPY_AND_ASSIGN(CryptoEngine); }; diff --git a/libwvdrmengine/oemcrypto/ref/src/oemcrypto_ref.cpp b/libwvdrmengine/oemcrypto/ref/src/oemcrypto_ref.cpp index a3941385..9ddf2c98 100644 --- a/libwvdrmengine/oemcrypto/ref/src/oemcrypto_ref.cpp +++ b/libwvdrmengine/oemcrypto/ref/src/oemcrypto_ref.cpp @@ -19,6 +19,7 @@ #include #include #include +#include #include #include "file_store.h" #include "log.h" @@ -64,8 +65,8 @@ extern "C" OEMCryptoResult OEMCrypto_Initialize(void) { } // NOTE: This requires a compatible Filesystem implementation. // NOTE: Ownership of the FileSystem object is transferred to CryptoEngine - scoped_ptr fs(new wvcdm::FileSystem()); - crypto_engine = CryptoEngine::MakeCryptoEngine(fs); + std::unique_ptr fs(new wvcdm::FileSystem()); + crypto_engine = CryptoEngine::MakeCryptoEngine(std::move(fs)); if (!crypto_engine || !crypto_engine->Initialize()) { LOGE("[OEMCrypto_Initialize(): failed]"); diff --git a/libwvdrmengine/oemcrypto/ref/src/oemcrypto_scoped_ptr.h b/libwvdrmengine/oemcrypto/ref/src/oemcrypto_scoped_ptr.h deleted file mode 100644 index 8e56fa03..00000000 --- a/libwvdrmengine/oemcrypto/ref/src/oemcrypto_scoped_ptr.h +++ /dev/null @@ -1,48 +0,0 @@ -// Copyright 2018 Google LLC. All Rights Reserved. This file and proprietary -// source code may only be used and distributed under the Widevine Master -// License Agreement. -#ifndef OEMCRYPTO_SCOPED_PTR_H_ -#define OEMCRYPTO_SCOPED_PTR_H_ - -#include -#include - -#include - -namespace wvoec_ref { - -// TODO(fredgc, jfore): scoped_ptr may not be the best name for this smart -// pointer type. It basically works like auto_ptr which is deprecated. -#if __cplusplus < 201103L - -template -class scoped_ptr { - public: - explicit scoped_ptr(T* p = NULL) : ptr_(p) {} - T* get() const { return ptr_.get(); } - void reset(T* p = NULL) { ptr_.reset(p); } - - private: - std::auto_ptr ptr_; -}; - -#else - -template -class scoped_ptr { - public: - explicit scoped_ptr(T* p = nullptr) : ptr_(p) {} - scoped_ptr(scoped_ptr& r) { ptr_ = std::move(r.ptr_); } - T& operator*() const { return *ptr_; } - T* operator->() const { return ptr_.get(); } - T* get() const { return ptr_.get(); } - void reset(T* p = NULL) { ptr_.reset(p); } - - private: - std::unique_ptr ptr_; -}; -#endif - -} // namespace wvoec_ref - -#endif // OEMCRYPTO_SCOPED_PTR_H_