From bfa8d39a633b3f641d6e603298c64208f9cfa93e Mon Sep 17 00:00:00 2001 From: Fred Gylys-Colwell Date: Wed, 22 Mar 2023 09:33:10 -0700 Subject: [PATCH] Remove some names Merge from Widevine repo of http://go/wvgerrit/168657 Some people who have left were still in OWNERS files and TODOs. Bug: 274772704 Test: comments only Change-Id: I583da815586e5ca52316b2e238d1c1bb3a5e919a --- OWNERS | 2 -- libwvdrmengine/Android.bp | 1 - libwvdrmengine/cdm/core/src/cdm_engine.cpp | 2 +- libwvdrmengine/cdm/core/src/service_certificate.cpp | 2 +- libwvdrmengine/cdm/test/cdm_extended_duration_test.cpp | 2 +- libwvdrmengine/cdm/test/request_license_test.cpp | 4 ++-- 6 files changed, 5 insertions(+), 8 deletions(-) diff --git a/OWNERS b/OWNERS index 2f5ce304..5fcbe21f 100644 --- a/OWNERS +++ b/OWNERS @@ -1,8 +1,6 @@ # Bug component: 59148 conglin@google.com -edwinwong@google.com fredgc@google.com -jtinker@google.com juce@google.com kelzhan@google.com kylealexander@google.com diff --git a/libwvdrmengine/Android.bp b/libwvdrmengine/Android.bp index 29ad5003..6dba7b24 100644 --- a/libwvdrmengine/Android.bp +++ b/libwvdrmengine/Android.bp @@ -315,7 +315,6 @@ cc_fuzz { srcs: ["src/fuzzer/fuzzer.cpp"], fuzz_config: { cc: [ - "edwinwong@google.com", "widevine-android@google.com", ], }, diff --git a/libwvdrmengine/cdm/core/src/cdm_engine.cpp b/libwvdrmengine/cdm/core/src/cdm_engine.cpp index 06122ba5..05fcc2cb 100644 --- a/libwvdrmengine/cdm/core/src/cdm_engine.cpp +++ b/libwvdrmengine/cdm/core/src/cdm_engine.cpp @@ -2063,7 +2063,7 @@ CdmResponseType CdmEngine::GetDecryptHashError(const CdmSessionId& session_id, return session->GetDecryptHashError(error_string); } -// TODO(gmorgan) Used? Delete if unused. +// TODO(rfrias) Used? Delete if unused. bool CdmEngine::IsKeyLoaded(const KeyId& key_id) { CdmSessionList sessions; session_map_.GetSessionList(sessions); diff --git a/libwvdrmengine/cdm/core/src/service_certificate.cpp b/libwvdrmengine/cdm/core/src/service_certificate.cpp index 1f2284a9..e3ae66c4 100644 --- a/libwvdrmengine/cdm/core/src/service_certificate.cpp +++ b/libwvdrmengine/cdm/core/src/service_certificate.cpp @@ -215,7 +215,7 @@ CdmResponseType ServiceCertificate::VerifySignedMessage( if (!public_key_->VerifySignature(message, signature)) return CdmResponseType( - CLIENT_ID_RSA_ENCRYPT_ERROR); // TODO(tinskip): Need new error code. + CLIENT_ID_RSA_ENCRYPT_ERROR); // TODO(rfrias): Need new error code. return CdmResponseType(NO_ERROR); } diff --git a/libwvdrmengine/cdm/test/cdm_extended_duration_test.cpp b/libwvdrmengine/cdm/test/cdm_extended_duration_test.cpp index 60b39708..304ba9a9 100644 --- a/libwvdrmengine/cdm/test/cdm_extended_duration_test.cpp +++ b/libwvdrmengine/cdm/test/cdm_extended_duration_test.cpp @@ -319,7 +319,7 @@ class WvCdmExtendedDurationTest : public WvCdmTestBase { *server_url = key_request.url; key_msg_ = key_request.message; EXPECT_EQ(kKeyRequestTypeRenewal, key_request.type); - // TODO(edwinwong, rfrias): Add tests cases for when license server url + // TODO(rfrias): Add tests cases for when license server url // is empty on renewal. Need appropriate key id at the server. EXPECT_NE(0u, key_request.url.size()); } diff --git a/libwvdrmengine/cdm/test/request_license_test.cpp b/libwvdrmengine/cdm/test/request_license_test.cpp index 49b7fbeb..13a87ac7 100644 --- a/libwvdrmengine/cdm/test/request_license_test.cpp +++ b/libwvdrmengine/cdm/test/request_license_test.cpp @@ -1885,7 +1885,7 @@ class WvCdmRequestLicenseTest : public WvCdmTestBase { key_msg_ = key_request.message; *server_url = key_request.url; EXPECT_EQ(kKeyRequestTypeRenewal, key_request.type); - // TODO(edwinwong, rfrias): Add tests cases for when license server url + // TODO(rfrias): Add tests cases for when license server url // is empty on renewal. Need appropriate key id at the server. EXPECT_NE(0u, key_request.url.size()); } @@ -4589,7 +4589,7 @@ TEST_F(WvCdmRequestLicenseTest, DISABLED_RestoreOfflineLicenseDecryptionTest) { decryptor_->CloseSession(session_id_); } -// TODO(rfrias, edwinwong): pending L1 OEMCrypto due to key block handling +// TODO(rfrias): pending L1 OEMCrypto due to key block handling /* TEST_F(WvCdmRequestLicenseTest, KeyControlBlockDecryptionTest) { decryptor_->OpenSession(config_.key_system(), &session_id_);