Commit Graph

2360 Commits

Author SHA1 Message Date
Rahul Frias
3d599197be Correct CryptoException error returned before keys have been loaded
[ Merge of http://go/wvgerrit/25983 ]

Earlier versions of android returned CryptoException with
error code ERROR_NO_KEY, when a decrypt call was received before keys were
loaded. Changes to O resulted in ERROR_SESSION_NOT_OPENED being returned
instead. This CL reverts the behaviour.

Also a change to correct CDM error code numbering in comments.

Test: Verified by unit and integration tests

b/37219830

Change-Id: I43758cd29cf9d1945f878ac352a5f26538b48cdb
2017-04-19 00:40:48 -07:00
Rahul Frias
f7c44ee4f7 Merge "Revert "Detect when unable to meet policy requirements"" into oc-dev am: 80798ae11c
am: 0f5f05f9cd

Change-Id: If1e958e1ed2be78a72fc37846b983a207a68a0a7
2017-04-18 20:56:39 +00:00
Rahul Frias
0f5f05f9cd Merge "Revert "Detect when unable to meet policy requirements"" into oc-dev
am: 80798ae11c

Change-Id: Ic5463e04aa477b8af351ea03436263514dafd9ec
2017-04-18 20:51:11 +00:00
Rahul Frias
80798ae11c Merge "Revert "Detect when unable to meet policy requirements"" into oc-dev 2017-04-18 20:37:22 +00:00
Rahul Frias
e733943729 Revert "Detect when unable to meet policy requirements"
This reverts commit 1223330ccc.

b/37460568

Change-Id: I936c06f679126ac50fb2d4753b4270b4ba42def5
2017-04-18 20:03:56 +00:00
John W. Bruce
c0a7655834 Maxing Out Sessions Can Cause SPOID Failures
(This is a merge of http://go/wvgerrit/25581)

To prevent dead DRM Plugins from being instantiated when there are no
sessions available, the time at which the device ID is queried has been
moved from instantiation-time to SPOID-calculation-time.

SPOIDs can now fail to be generated. Which means anything that depends
on a SPOID may fail because of this. However, this is a more actionable
problem for apps than having them receive a dead or unusable DRM Plugin
object.

Bug: 36660726
Test: libwvdrmdrmplugin_hidl_test
Change-Id: Ice6a8eabfee8d48bf2af02e2e7169aa95af9f2e4
2017-04-18 10:25:39 -07:00
John W. Bruce
19947dfe6f Move SPOID Enable/Disable Logic Out of WVDrmPlugin
(This is a merge of http://go/wvgerrit/25580)

While writing fixes for b/36660726, b/34716264, and b/36065223, it
became clear that having the logic that checks whether the device
supports SPOIDs embedded inside WVDrmPlugin was complicating its code
and inhibiting testing of the class. By moving this check into the code
that instantiates WVDrmPlugin, the result of the calculation can be
independently tested while the tests for WVDrmPlugin can put it in
whatever state they need for the sake of unit testing.

As a consequence of this, the check on retrieving the "deviceUniqueId"
byte array property, which was removed when SPOIDs were implemented, can
be reinstated.

Bug: 36660726
Bug: 34716264
Bug: 36065223
Test: libwvdrmdrmplugin_hidl_test & libwvdrmengine_hidl_test
Change-Id: I961d2ee42bbdc42f0c324e36d9a74ac92205a437
2017-04-18 09:56:58 -07:00
Rahul Frias
92ef632596 Merge "Detect when unable to meet policy requirements" into oc-dev am: 551f4cb474
am: 3bf36c4321

Change-Id: I53bc708174ff281581065d80e822110ae870ea1d
2017-04-15 06:58:33 +00:00
Rahul Frias
3bf36c4321 Merge "Detect when unable to meet policy requirements" into oc-dev
am: 551f4cb474

Change-Id: Ic0a7095525471ca0ebb514a396aae352c23e5311
2017-04-15 06:55:54 +00:00
Rahul Frias
551f4cb474 Merge "Detect when unable to meet policy requirements" into oc-dev 2017-04-15 06:50:05 +00:00
Rahul Frias
66549ec1e1 Merge "Correct KeySetId value when returned by AddKey" into oc-dev am: f655f329e2
am: 16e76d3bb5

Change-Id: Ia5de9c3ce85d48d16a73094ca5543bf1a559a50a
2017-04-15 06:43:32 +00:00
Rahul Frias
16e76d3bb5 Merge "Correct KeySetId value when returned by AddKey" into oc-dev
am: f655f329e2

Change-Id: I0d1225d188edae07945a6f687abd5ef99a8f969c
2017-04-15 06:40:51 +00:00
Rahul Frias
f655f329e2 Merge "Correct KeySetId value when returned by AddKey" into oc-dev 2017-04-15 06:37:06 +00:00
Fred Gylys-Colwell
cab913f848 Undo bad merge
This CL undoes the merge cc28abea0b by
TreeHugger that should not have gone to master.  We re-enable a unit
tests that is required for OC MR1, but is not required for OC.

It also includes a minor change that allows the oemcrypto mock to be
built by an Android NDK:
Merge from Widevine repo of http://go/wvgerrit/24681

b/31458046
b/35141278

Change-Id: I8edc51504a16f1825ef765aeaff6f77f034f0362
2017-04-15 00:38:11 +00:00
Rahul Frias
57bb6c29ca Add usage information tests to device files unit tests
[ Merge of http://go/wvgerrit/24445 ]

Test: Verified by wv unit and integration tests

b/36048120

Change-Id: I9d067e79654331e8e58df5dce5411fbadc73e575
2017-04-14 15:12:25 -07:00
Jeff Tinker
1e9fe59e9c Merge "Translate CDM session not opened errors" into oc-dev am: 6116fdb97a
am: 5ea9fc8cb4

Change-Id: I62a9982c0737399fdd36bce171026462747fa0b6
2017-04-14 21:47:23 +00:00
Jeff Tinker
11c9dc0b98 Merge "Add an offline test asset for the drm vts test" into oc-dev am: 45910edd19
am: b2e501c1e4

Change-Id: I14d0507d1247ab9c72c1829af1fec298638fbac8
2017-04-14 21:47:22 +00:00
Jeff Tinker
5ea9fc8cb4 Merge "Translate CDM session not opened errors" into oc-dev
am: 6116fdb97a

Change-Id: I9d888f35db146164f52e9450107fce76d4448316
2017-04-14 21:44:55 +00:00
Jeff Tinker
b2e501c1e4 Merge "Add an offline test asset for the drm vts test" into oc-dev
am: 45910edd19

Change-Id: I6c7db741362d17acee78d1abd28b12e906da9e23
2017-04-14 21:44:53 +00:00
TreeHugger Robot
6116fdb97a Merge "Translate CDM session not opened errors" into oc-dev 2017-04-14 21:38:30 +00:00
TreeHugger Robot
45910edd19 Merge "Add an offline test asset for the drm vts test" into oc-dev 2017-04-14 21:38:30 +00:00
Iliyan Malchev
0591d7315e Route drm@1.0-service.widevine libbinder to /dev/vndbinder am: 28b89a9b4f
am: 22169f63e8

Change-Id: I5c734f0d04c7464cc41da6c546e730d530765c16
2017-04-14 18:45:10 +00:00
Iliyan Malchev
22169f63e8 Route drm@1.0-service.widevine libbinder to /dev/vndbinder
am: 28b89a9b4f

Change-Id: I7dd7634546dd780a34423e48be47807030e9b90a
2017-04-14 18:25:12 +00:00
Rahul Frias
5321b96623 Correct KeySetId value when returned by AddKey
[ Merge of http://go/wvgerrit/25643 ]

The MediaDrm#provideKeyResponse API states that an empty byte array is
returned when the license type is streaming or release but a non-empty
value was being returned in some cases.

The KeySetId is now returned when the license type is offline or when
the license is streaming and has a secure stop associated with it.

Test: Verified by request_license_test integration tests. Tests have been
      modified to validate the returned Key Set Id values.

b/36093612

Change-Id: I82dba537c77ddd1d1876cbce58729f3db901ee51
2017-04-14 07:54:01 -07:00
Iliyan Malchev
28b89a9b4f Route drm@1.0-service.widevine libbinder to /dev/vndbinder
b/37309712: [Marlin/Sailfish] Fatal signal 6 (SIGABRT) when playing Exo
	    Player L1 encrypted content
Test: marlin

Change-Id: I05b12ea334138498be13bca92c9b1db6ed1b9870
Signed-off-by: Iliyan Malchev <malchev@google.com>
2017-04-14 01:22:04 -07:00
Jeff Tinker
3914953bff Add an offline test asset for the drm vts test
To test restoreKeys, a content configuration with a
license policy allowing offline playaback was needed.

Test: drm vts test

bug:34178477
Change-Id: Ib90d7a878c0f310569abb09f21138c7a6ac9daae
2017-04-14 00:30:07 -07:00
Jeff Tinker
f5240b69e4 Translate CDM session not opened errors
The drm hidl hal specifies that operations on sessions that
are not opened return ERROR_DRM_SESSION_NOT_OPENED.  This
change adds that translation, previously they were mapped
to unknown error.

Test: drm vts test

bug:34178477
Change-Id: I3777dd90eea7061f3fa5413a5732d7d58b85b49b
2017-04-14 00:28:47 -07:00
Jeff Tinker
0c7a6a3f76 Merge "Corrections to widevine plugin for vts tests" into oc-dev am: c3ea64aa89
am: a40302e208

Change-Id: I53b2457631663a9f55ae904fb770fdc564f31fd3
2017-04-14 01:03:06 +00:00
Jeff Tinker
a40302e208 Merge "Corrections to widevine plugin for vts tests" into oc-dev
am: c3ea64aa89

Change-Id: Ic8076eb4b4634734126d362a5d0032a1a6d27c58
2017-04-14 00:12:28 +00:00
TreeHugger Robot
c3ea64aa89 Merge "Corrections to widevine plugin for vts tests" into oc-dev 2017-04-14 00:05:42 +00:00
Rahul Frias
1223330ccc Detect when unable to meet policy requirements
[ Merge of http://go/wvgerrit/25781 ]

The security level (software/hardware, decryption/decode)
in the policy that specified how the key was to be used was
not being respected for L3. Playback would either continue or
a vendor specific error would be thrown.

If the device cannot use the key as permitted by the policy
CryptoException#ERROR_INSUFFICIENT_OUTPUT_PROTECTION will be thrown.

Test: Verified by WV unit+integration tests.
      Verified by WidevineDashPolicyTests
      Verified by WidevineDashPolicyTests#testL3SoftwareSecureDecoderRequired,
      testL3HardwareSecureCryptoRequired, testL3HardwareSecureDecodeRequired,
      testL3SecureVideoPathRequired.

b/31913737
b/31913439

Change-Id: Ibfc7f3dd6fc7264e8cf9b0d33f6f8d619eed6c00
2017-04-13 16:50:10 -07:00
Jeff Tinker
6c15ea673d Corrections to widevine plugin for vts tests
Add a check for invalid session size in restoreKeys
and correct the return code when attempting to create a
plugin with an invalid uuid. Also correct the return code
when attempting to decrypt after keys have been removed.

bug:37172151
Change-Id: I7e832ffe04081471a0cdb3a9329808f47f12cfc3
2017-04-13 14:53:12 -07:00
Rahul Frias
4007f35a65 Correct error returned when license is for the future am: ce62e1d7e7
am: 8b0edd6481

Change-Id: I4f28c30b7855d6fa394cf406af01b17e1740b4f6
2017-04-13 01:36:15 +00:00
Rahul Frias
8b0edd6481 Correct error returned when license is for the future
am: ce62e1d7e7

Change-Id: Idaac6fec1faa0df3a41a5aa29b173a4985f6b0cd
2017-04-13 01:29:54 +00:00
Rahul Frias
ce62e1d7e7 Correct error returned when license is for the future
[ Merge of http://go/wvgerrit/25721 ]

Return CryptoException with errorCode ERROR_NO_KEY when an attempt is made
to make use of a license whose start time is in the future.

Test: Verified by WidevineDashPolicyTests#testL1LicenseStart2030

b/31914841

Change-Id: I2a157c227550a2391b6536365f34f1dfec3dea0c
2017-04-12 13:20:44 -07:00
John Bruce
67650139cc Merge "Always Report OEMCrypto_ERROR_KEY_EXPIRED as NEED_KEY" into oc-dev am: 1b0d67f368
am: d7d5715f21

Change-Id: I440476def9aaf85d145b0e97df9d8f60d844b4d3
2017-04-12 18:24:55 +00:00
John Bruce
d7d5715f21 Merge "Always Report OEMCrypto_ERROR_KEY_EXPIRED as NEED_KEY" into oc-dev
am: 1b0d67f368

Change-Id: Ib99df99fbb441f67a4cab52c45095287e05cd532
2017-04-12 18:08:50 +00:00
John Bruce
1b0d67f368 Merge "Always Report OEMCrypto_ERROR_KEY_EXPIRED as NEED_KEY" into oc-dev 2017-04-12 17:48:58 +00:00
Fred Gylys-Colwell
f59fc8cb86 Merge "Disable MinVersionNumber13 Test *DO NOT MERGE*" into oc-dev am: cc28abea0b
am: 4c5ae08575

Change-Id: I9b6e0655278407cb1aa8b8bf6f2de7b94b68794d
2017-04-12 01:47:04 +00:00
Fred Gylys-Colwell
4c5ae08575 Merge "Disable MinVersionNumber13 Test *DO NOT MERGE*" into oc-dev
am: cc28abea0b

Change-Id: I6d284dc2a9dde9b6e4f5b578aa56423d07431a4f
2017-04-12 01:41:53 +00:00
TreeHugger Robot
cc28abea0b Merge "Disable MinVersionNumber13 Test *DO NOT MERGE*" into oc-dev 2017-04-12 01:37:18 +00:00
Fred Gylys-Colwell
87040f8157 Merge "Address merge comments" into oc-dev am: dbaacf9232
am: 565d911792

Change-Id: I8ea37fe2f027886252f2bed9b525a7c69de261b0
2017-04-12 00:38:41 +00:00
Fred Gylys-Colwell
565d911792 Merge "Address merge comments" into oc-dev
am: dbaacf9232

Change-Id: Ia8f793fa61b98aa8391468808fa5b75b5ff7c1c1
2017-04-12 00:21:58 +00:00
TreeHugger Robot
dbaacf9232 Merge "Address merge comments" into oc-dev 2017-04-11 23:57:19 +00:00
Rahul Frias
b474ba042e Allow OfflineLicenseRenewal test to be repeatedly invoked
[ Merge of http://go/wvgerrit/25720 ]

Test: Repeatedly invoke WvCdmRequestLicenseTest.OfflineLicenseRenewal

b/28915200

Change-Id: I5be6be02d09ced1a7ba8bac2c8706f199d063db8
2017-04-11 16:40:16 -07:00
Jeff Tinker
158769ce28 Merge "Report binderized vendor service name" into oc-dev am: eef94c002f
am: 70d8036881

Change-Id: I506d0d71fa7ad54a6ac939800d78f322d17a18d0
2017-04-11 21:28:54 +00:00
Jeff Tinker
ef9d80f562 Merge "Add checks for invalid parameters" into oc-dev am: 9a69579330
am: c95756d367

Change-Id: I625efab0eaee64250dd040f8bec9a796fc68a18a
2017-04-11 21:28:45 +00:00
Jeff Tinker
70d8036881 Merge "Report binderized vendor service name" into oc-dev
am: eef94c002f

Change-Id: I7b0a17b2cb1328df14cf771ecd01908eb8e3a427
2017-04-11 21:20:11 +00:00
Jeff Tinker
c95756d367 Merge "Add checks for invalid parameters" into oc-dev
am: 9a69579330

Change-Id: Ic1c9fcb851e7c8ce7027ce620c9ac053f24a81b1
2017-04-11 21:20:01 +00:00
TreeHugger Robot
eef94c002f Merge "Report binderized vendor service name" into oc-dev 2017-04-11 21:02:21 +00:00