Commit Graph

1214 Commits

Author SHA1 Message Date
Fred Gylys-Colwell
62a9cf3cbe Terminate Level 1 OEMCrypto on Initialization Error
Cherry pick of the widevine change
https://widevine-internal-review.googlesource.com/#/c/12082/

If the level 1 oemcrypto library loads and initializes, but has the
wrong version or does not have a valid keybox, then the level 3
fallback is used.   However, in those cases, the level 1 was not
terminated properly.  This caused a resource leak on some platforms.

With this CL, in OEMCrypto_Initialize, the level 1 library Terminate
is called if its Initialize was called and the level 1 library will
not be used.

bug: 18755226
Change-Id: I56e7d3349eeebd94f3fa8c4a1f4b21781cc7428b
2014-12-17 11:29:14 -08:00
Jeff Tinker
f4018c95c5 am b4cd98c3: am 07478a67: Ensure terminate is called in all error cases
* commit 'b4cd98c39d9e726c18c77e96c2cd9774d0512f86':
  Ensure terminate is called in all error cases
2014-12-12 21:56:24 +00:00
Jeff Tinker
b4cd98c39d am 07478a67: Ensure terminate is called in all error cases
* commit '07478a67cb9e291e60be3dea8eb70b716568ba1f':
  Ensure terminate is called in all error cases
2014-12-12 21:49:17 +00:00
Jeff Tinker
513740ee46 am d5b04d64: am 4dd74859: Fix illegal instruction fault in libwvdrmengine.so
* commit 'd5b04d6430749599416f1a627818b952c908f620':
  Fix illegal instruction fault in libwvdrmengine.so
2014-12-12 14:49:58 +00:00
Jeff Tinker
d5b04d6430 am 4dd74859: Fix illegal instruction fault in libwvdrmengine.so
* commit '4dd748597a26bdff6138fc20ed17baa32bf89ab8':
  Fix illegal instruction fault in libwvdrmengine.so
2014-12-12 14:42:27 +00:00
Jeff Tinker
07478a67cb Ensure terminate is called in all error cases
bug: 18203007
Change-Id: I0d74b348982992075ec126a324dabbff8fab9125
2014-12-11 19:27:50 -08:00
Jeff Tinker
4dd748597a Fix illegal instruction fault in libwvdrmengine.so
Merge of https://widevine-internal-review.googlesource.com/#/c/12020/
from the widevine CDM repo.

bug: 18606686
Change-Id: Iafc27f51c8d486065620c9140ce88b285fc0067c
2014-12-12 00:56:19 +00:00
Rong Xu
1fc28e7db3 am 31aa16fb: Fix gcc-4_9 warning
* commit '31aa16fbaba00537ab68256248eb049ae71e0790':
  Fix gcc-4_9 warning
2014-12-09 23:22:57 +00:00
Chong Zhang
283c199c10 am 4e600be6: am 0c752509: Merge "widevine: return -EAGAIN sooner in non-blocking mode" into lmp-mr1-dev
* commit '4e600be65ab68461633ccd59915635984aaee32b':
  widevine: return -EAGAIN sooner in non-blocking mode
2014-12-09 23:03:34 +00:00
Rong Xu
31aa16fbab Fix gcc-4_9 warning
Fix a warning in gcc-4.9:
In file included from
vendor/widevine/libwvdrmengine/cdm/core/src/max_res_engine.cpp:3:0:
vendor/widevine/libwvdrmengine/cdm/core/include/max_res_engine.h:56:9:
error: 'class wvcdm::MaxResEngine::KeyStatus' is private
   class KeyStatus {
         ^
vendor/widevine/libwvdrmengine/cdm/core/src/max_res_engine.cpp:10:53:
error: within this context
 typedef std::map<wvcdm::KeyId,
wvcdm::MaxResEngine::KeyStatus*>::const_iterator

(cherry picked from commit 944d085a79)

Change-Id: I4984bd52c52c36e59c4d09db5e4f4d581e577b07
2014-12-09 11:20:24 +01:00
Fred Gylys-Colwell
293659b808 am f47b8c81: am d2ca9d44: Merge "Level 3 OEMCrypto library for mips" into lmp-mr1-dev
* commit 'f47b8c813a68d73cd41dc0e12934b88451c69bbc':
  Level 3 OEMCrypto library for mips
2014-12-09 00:57:04 +00:00
Fred Gylys-Colwell
968a6cf948 am 5ea1279e: am 1811a8ac: Level 3 OEMCrypto library for x86
* commit '5ea1279eefb454ff80c7eb019459e2d03dc41cab':
  Level 3 OEMCrypto library for x86
2014-12-09 00:57:03 +00:00
Chong Zhang
4e600be65a am 0c752509: Merge "widevine: return -EAGAIN sooner in non-blocking mode" into lmp-mr1-dev
* commit '0c7525090f326a712724f864224323080a4cf026':
  widevine: return -EAGAIN sooner in non-blocking mode
2014-12-08 19:35:08 +00:00
Fred Gylys-Colwell
f47b8c813a am d2ca9d44: Merge "Level 3 OEMCrypto library for mips" into lmp-mr1-dev
* commit 'd2ca9d448e135ea48e5c8c6eb0e8b87c193c07cd':
  Level 3 OEMCrypto library for mips
2014-12-08 19:13:58 +00:00
Fred Gylys-Colwell
5ea1279eef am 1811a8ac: Level 3 OEMCrypto library for x86
* commit '1811a8ac12873c2c1d2a1ac215d04829868da1a8':
  Level 3 OEMCrypto library for x86
2014-12-08 19:13:58 +00:00
Chong Zhang
0c7525090f Merge "widevine: return -EAGAIN sooner in non-blocking mode" into lmp-mr1-dev 2014-12-05 23:31:39 +00:00
Chong Zhang
35b42afd0f widevine: return -EAGAIN sooner in non-blocking mode
Bug: 18536934

Change-Id: Ib9344851fceb418a2e614e966c981a997c32c466
2014-12-05 11:33:00 -08:00
Fred Gylys-Colwell
d2ca9d448e Merge "Level 3 OEMCrypto library for mips" into lmp-mr1-dev 2014-12-05 02:57:26 +00:00
Fred Gylys-Colwell
cb9360fb65 Level 3 OEMCrypto library for mips
This CL is a merge of the widevine change
https://widevine-internal-review.googlesource.com/#/c/11881

The function rand() was not available on the mips build used to
generate the level 3 oemcrypto fallback library.  This function has
been replaced by the openssl RAND_bytes(), so that compilation may
complete.

New version of library:
libwvdrmengine/level3/mips/libwvlevel3.a  NONOB Level3 Library Dec  3 2014 17:11:00

bug: 17288466
Change-Id: Ibe2ae3add4f5830ddc1cce501d76aeb4be5ce926
2014-12-03 17:39:50 -08:00
Rong Xu
944d085a79 Fix gcc-4_9 warning
Fix a warning in gcc-4.9:
In file included from
vendor/widevine/libwvdrmengine/cdm/core/src/max_res_engine.cpp:3:0:
vendor/widevine/libwvdrmengine/cdm/core/include/max_res_engine.h:56:9:
error: 'class wvcdm::MaxResEngine::KeyStatus' is private
   class KeyStatus {
         ^
vendor/widevine/libwvdrmengine/cdm/core/src/max_res_engine.cpp:10:53:
error: within this context
 typedef std::map<wvcdm::KeyId,
wvcdm::MaxResEngine::KeyStatus*>::const_iterator

Change-Id: Ic92676d09c84582de18091a91ea8742a6faf05e7
2014-12-03 15:58:58 -08:00
Fred Gylys-Colwell
1811a8ac12 Level 3 OEMCrypto library for x86
This is a merge of the Widevine change:
https://widevine-internal-review.googlesource.com/#/c/11871

The level 3 oemcrypto fall back now compiles cleanly on a Fugu, and
passes all unit tests.

New version of library:
libwvdrmengine/level3/x86/libwvlevel3.a  Level3 Library Dec  3 2014 13:06:03

bug: 17289103

Change-Id: I677888536dd2ca12e27b5985737e080b69d81477
2014-12-03 13:28:57 -08:00
Dan Albert
04a484762d am 67099326: Fix build.
* commit '670993262f57c37890cb4b1c600faa4a49434829':
  Fix build.
2014-11-26 03:12:44 +00:00
Dan Albert
670993262f Fix build.
This project is still using stlport (without telling the build system
about it), which was causing (broken) stlport headers to override
libc++ headers, leading to a broken copy of std::enable_if, which in
turn caused <atomic> to fail to compile. Since this project has
prebuilts that will need to be updated before this project can
actually move away from stlport, tell the build system that it is
still using stlport for now.

Bug: 18433002
Change-Id: I38b356428977ed2184eb28a07bd5e7424a4ace8d
(cherry picked from commit de4bc34719)
2014-11-26 03:05:50 +00:00
Dan Albert
0018a108f9 Merge "Fix build." 2014-11-25 21:42:07 +00:00
Dan Albert
de4bc34719 Fix build.
This project is still using stlport (without telling the build system
about it), which was causing (broken) stlport headers to override
libc++ headers, leading to a broken copy of std::enable_if, which in
turn caused <atomic> to fail to compile. Since this project has
prebuilts that will need to be updated before this project can
actually move away from stlport, tell the build system that it is
still using stlport for now.

Bug: 18433002
Change-Id: I38b356428977ed2184eb28a07bd5e7424a4ace8d
2014-11-25 13:41:47 -08:00
Rahul Frias
045c6f614a am 3a586ab2: Report HDCP status of no HDCP device attached
* commit '3a586ab27bb8b5621e12b07fa6a8f1ed5da354a8':
  Report HDCP status of no HDCP device attached
2014-11-25 17:48:15 +00:00
Rahul Frias
3a586ab27b Report HDCP status of no HDCP device attached
OEMCrypto may report an HDCP status of "No HDCP device attached/using
local display with secure path". This is not propagated upto
the server as an appropriate HDCP value did not exist in the
license protocol. This has now been added. Netflix has requested that
this be reported.

[ Merge of https://widevine-internal-review.googlesource.com/#/c/11806/
  from Widevine cdm repo ]

b/18377309

Change-Id: I3db88c7ab5e79a3c12dbc8a398c4770e14e5ee5c
2014-11-22 01:46:13 -08:00
Fred Gylys-Colwell
967a9704d0 am 5acf3cdc: Save and load usage table in level 3 OEMCrypto
* commit '5acf3cdc3d0c3837267601254a99d336d621e5c0':
  Save and load usage table in level 3 OEMCrypto
2014-11-20 21:23:45 +00:00
Fred Gylys-Colwell
5acf3cdc3d Save and load usage table in level 3 OEMCrypto
This is a merge of the widevine change:
https://widevine-internal-review.googlesource.com/#/c/11781

The OEMCrypto did not save the usage table correctly after a key was
loaded and not used.

Also, oemcrypto uses the keybox to verify and sign the usage table.
On library initialization, the usage table was being loaded before the
keybox, so the signature was not verified correctly.

Both these problems have been corrected.

Current Library Version:
arm:  Level3 Library Nov 19 2014 16:53:43

bug: 17328418 Can't play pinned content
Change-Id: Ia753e2f47b36433931fbe8dba78939581e647222
2014-11-19 17:02:33 -08:00
Rahul Frias
799368207f am dffa3ca9: Merge "MediaDrm throws an exception when Secure Stops are requested" into lmp-mr1-dev
* commit 'dffa3ca991c64035e1852543a215f99935b58c7f':
  MediaDrm throws an exception when Secure Stops are requested
2014-11-14 20:45:36 +00:00
Rahul Frias
dffa3ca991 Merge "MediaDrm throws an exception when Secure Stops are requested" into lmp-mr1-dev 2014-11-14 17:34:14 +00:00
Fred Gylys-Colwell
7d62c39b77 am 9810ff89: Merge "Accept new signing keys for no renewal license" into lmp-mr1-dev
* commit '9810ff8925cb2a82f7423eddb776e9bbd5a8ec4d':
  Accept new signing keys for no renewal license
2014-11-14 00:44:15 +00:00
Rahul Frias
aa7ad630d7 MediaDrm throws an exception when Secure Stops are requested
Our recommendation to OEMs is that they support a table of at least 50
usage entries in OEMCrypto. If more usage entries are stored, the PSTs get
added to the CDM but are LRU'ed out of the OEMCrypto usage table. When the
CDM queries those usage entries, OEMCrypto will return a
OEMCrypto_ERROR_INVALID_CONTEXT. Rather than return an error and have
MediaDrm throw an exception, CDM should delete this PST and return the
next usage entry, when queried.

[ Merge of https://widevine-internal-review.googlesource.com/#/c/11457/
  from Widevine cdm repo ]

b/17994711

Change-Id: I00e3f93000096fb434d94333e22958de795a4bb5
2014-11-13 12:56:26 -08:00
Fred Gylys-Colwell
9810ff8925 Merge "Accept new signing keys for no renewal license" into lmp-mr1-dev 2014-11-13 17:13:23 +00:00
Fred Gylys-Colwell
a8e11ead04 am 3b1a3e47: Merge "Adjust CDM engine and request license unit tests" into lmp-mr1-dev
* commit '3b1a3e47d8c52e40cdf9c4eabe854d8a04c8aa7f':
  Adjust CDM engine and request license unit tests
2014-11-13 02:18:10 +00:00
Fred Gylys-Colwell
3b1a3e47d8 Merge "Adjust CDM engine and request license unit tests" into lmp-mr1-dev 2014-11-13 01:12:22 +00:00
Fred Gylys-Colwell
c325b3aec3 Accept new signing keys for no renewal license
Merge of widevine change
https://widevine-internal-review.googlesource.com/#/c/11501/

A license response can have new signing (mac) keys attached whether
the license can be renewed or not.  Previously, the new keys were
ignored if the license could not be renewed.

bug: 18009750 Secure stop release generation failing for Netflix

Change-Id: I06dd76b0ab9f459021f46eecc938aa43d8d29689
2014-11-12 16:29:42 -08:00
Fred Gylys-Colwell
9ff5125867 Adjust CDM engine and request license unit tests
Merge of the widevine change:
https://widevine-internal-review.googlesource.com/#/c/11632

Several unit tests in cdm_engine_test.cpp and request_license_test.cpp
were failing regularly. These were caused by either:
1) The device was not provisioned.
  This has been fixed by adding a certificate provisioning step in the
  test setup for the cdm engine tests and changing the existing
  provision steop in the request license tests to provision for both
  security levels.
2) The device was hitting a flaky server.
  This has been fixed by switching from the GooglePlayServer to the
  Widevine server.
3) A null pointer introduced when testing secure stops with an app
  id.  This has been fixed by directly injecting the app id in the unit
  tests.
4) Flaky network connections.  The unit tests were requesting data
  from the server and were timing out after 3 seconds.  I changed that
  to 12 seconds.
5) The tests were searching for an end-of-line marker to find the GLS
  header in the license response message.  The end-of-line marker was
  present in a valid DRM message for almost 1% of the test cases.  This
  code  has been replaced by searching for the string "GLS/1" at the
  begining of the HTML body.

I also added test_printers.cpp that defines functions used by GTest to
print error codes by name instead of numeric value.

This CL changes unit tests only. It does not change any production
code.

bug: 18316036

Change-Id: I3398580059a03114e782ac7ac59e6b0944012df4
2014-11-12 13:57:03 -08:00
John "Juce" Bruce
0f143e248b am abbef3d0: Merge "Fix Typos in License.cpp" into lmp-mr1-dev
* commit 'abbef3d0023ae1f7a8d4dd9e167e1e92ebc61cf1':
  Fix Typos in License.cpp
2014-11-07 22:04:06 +00:00
John "Juce" Bruce
abbef3d002 Merge "Fix Typos in License.cpp" into lmp-mr1-dev 2014-11-07 21:33:24 +00:00
John "Juce" Bruce
4d695de2b0 Fix Typos in License.cpp
(This is a merge of http://go/wvgerrit/11626 in the Widevine CDM
repo.)

Change-Id: Iad48e76a77c285c0e0738b22436dc60cb3704740
2014-11-07 13:21:40 -08:00
John "Juce" Bruce
1d7fb7cdf8 Merge "Add OS Version to Properties" into lmp-mr1-dev
automerge: 039b984

* commit '039b984a752f96038db15922181c7a9ff9736694':
  Add OS Version to Properties
2014-11-07 20:35:46 +00:00
John "Juce" Bruce
039b984a75 Merge "Add OS Version to Properties" into lmp-mr1-dev 2014-11-07 20:04:55 +00:00
John "Juce" Bruce
31f87bc19e Add OS Version to Properties
(This is a merge of http://go/wvgerrit/11613 from the Widevine CDM
repo.)

Adds a property for the OS version, implements it on Android, and
adds it to the license request property bag so that Netflix may
use it to discern the supported capabilities of the CDM.

Bug: 18230738
Change-Id: If5174a108093855314f3e0102b83691e20bb247b
2014-11-07 11:47:51 -08:00
Fred Gylys-Colwell
f9b4b25f46 Merge "Adjust PreventNonceFlood tests" into lmp-mr1-dev
automerge: def3c4d

* commit 'def3c4d5b8aa7739bf8d686399f5e49e84a2ffa0':
  Adjust PreventNonceFlood tests
2014-11-07 19:43:25 +00:00
Fred Gylys-Colwell
def3c4d5b8 Merge "Adjust PreventNonceFlood tests" into lmp-mr1-dev 2014-11-07 19:27:22 +00:00
Edwin Wong
e9091b30db am 59da4188: Remove corrupted license file from storage.
* commit '59da4188833cf281043a08deb788e59cca23b153':
  Remove corrupted license file from storage.
2014-11-07 15:29:28 +00:00
Fred Gylys-Colwell
2ca704e5c0 Adjust PreventNonceFlood tests
The OEMCrypto library should prevent too many nonces from occuring in
a row. Previously, we tested that GenerateNonce generated an error if
there were too many nonce requests.

This CL makes it possible for OEMCrypto to delay the return from
GenerateNonce if there are too many requests.  This is an equally
valid solution to the nonce flood attack.

This is a unit test change only.  No production code is affected.

This is a merge from the widevine repository of:
https://widevine-internal-review.googlesource.com/#/c/11604/

bug: 17630253
Change-Id: Ie97f712d70230cd8e7ea7089da0aa18039673bb4
2014-11-06 22:12:51 -08:00
Alvin Huang
791d35e726 am fb651077: Try to fix the build break caused by WVMExtractorImpl.cpp
* commit 'fb651077bae9ac717e32470ec7db0dc69997efc5':
  Try to fix the build break caused by WVMExtractorImpl.cpp
2014-11-07 04:13:04 +00:00
Edwin Wong
59da418883 Remove corrupted license file from storage.
(This is a port of http://go/wvgerrit/11614 from the
 Widevine repo.)

CDM does not recover if a license file has invalid size
or the hash is incorrect. Remove the corrupted license
file in such cases.

bug: 18002606

Change-Id: I46dec853ce6b2e7c7430297d50df5d30488cde3b
2014-11-06 17:07:48 -08:00