Source release 16.3.0

third_party/boringssl/boringssl.gyp

@@ -13,14 +13,17 @@
       '-fvisibility=hidden',
       # BoringSSL violates these warnings
       '-Wno-cast-qual',
+      '-Wno-ignored-qualifiers',
     ],
     'cflags!': [
       '-Wbad-function-cast',
       '-Wcast-qual',
+      '-Wignored-qualifiers',
     ],
     'cflags_cc!': [
       '-Wbad-function-cast',
       '-Wcast-qual',
+      '-Wignored-qualifiers',
     ],
     'cflags_c': [
       # BoringSSL violates these warnings
@@ -29,6 +32,7 @@
     'cflags_c!': [
       '-Wbad-function-cast',
       '-Wcast-qual',
+      '-Wignored-qualifiers',
     ],
 
     'msvs_settings': {
@@ -41,15 +45,14 @@
     'ldflags': [
       '-fPIC',
     ],
-    'link_settings': {
-      'ldflags': [
-        '-lpthread',
-      ],
-    },
 
     'link_settings': {
       'conditions': [
-        ['OS=="win"', {
+        ['OS!="win"', {
+          'libraries': [
+            '-lpthread',
+          ],
+        }, {
           'libraries': [
             '-ladvapi32',
           ],
@@ -62,10 +65,12 @@
       'cflags': [
         '-Wno-unknown-warning-option',
         '-Wno-cast-qual',
+        '-Wno-ignored-qualifiers',
       ],
       'cflags!': [
         '-Wbad-function-cast',
         '-Wcast-qual',
+        '-Wignored-qualifiers',
       ],
       'cflags_c': [
         '-Wno-bad-function-cast',
@@ -73,10 +78,12 @@
       'cflags_c!': [
         '-Wbad-function-cast',
         '-Wcast-qual',
+        '-Wignored-qualifiers',
       ],
       'cflags_cc!': [
         '-Wbad-function-cast',
         '-Wcast-qual',
+        '-Wignored-qualifiers',
       ],
     },
 

third_party/gmock.gyp

@@ -12,6 +12,11 @@
     ],
     'cflags_cc': [
       '-std=c++11',
+      # gMock violates these warnings
+      '-Wno-deprecated-copy',
+    ],
+    'cflags_cc!': [
+      '-Wdeprecated-copy',
     ],
     'ldflags': [
       '-fPIC',
@@ -27,6 +32,13 @@
         'googletest/googlemock/include',
         'googletest/googletest/include',
       ],
+      'cflags_cc': [
+        # gMock's exported headers violate these warnings
+        '-Wno-deprecated-copy',
+      ],
+      'cflags_cc!': [
+        '-Wdeprecated-copy',
+      ],
       'xcode_settings': {
         'OTHER_CFLAGS': [
           '-Wno-inconsistent-missing-override',
@@ -65,7 +77,7 @@
       'conditions': [
         ['OS!="win"', {
           'link_settings': {
-            'ldflags': [
+            'libraries': [
               '-lpthread',
             ],
           },

third_party/gyp/xcode_emulation.py

@@ -726,6 +726,8 @@ class XcodeSettings(object):
   def _AddObjectiveCARCFlags(self, flags):
     if self._Test('CLANG_ENABLE_OBJC_ARC', 'YES', default='NO'):
       flags.append('-fobjc-arc')
+    if self._Test('CLANG_ENABLE_OBJC_WEAK', 'YES', default='NO'):
+      flags.append('-fobjc-weak')
 
   def _AddObjectiveCMissingPropertySynthesisFlags(self, flags):
     if self._Test('CLANG_WARN_OBJC_MISSING_PROPERTY_SYNTHESIS',