Refactor and cleanup codes. No functional changes.
This commit is contained in:
@@ -1,5 +1,5 @@
|
||||
////////////////////////////////////////////////////////////////////////////////
|
||||
// Copyright 2016 Google Inc.
|
||||
// Copyright 2016 Google LLC.
|
||||
//
|
||||
// This software is licensed under the terms defined in the Widevine Master
|
||||
// License Agreement. For a copy of this agreement, please contact
|
||||
@@ -8,19 +8,20 @@
|
||||
|
||||
#include "provisioning_sdk/internal/oem_device_cert.h"
|
||||
|
||||
#include "gtest/gtest.h"
|
||||
#include "provisioning_sdk/internal/certificates/test_certificates.h"
|
||||
#include "testing/gunit.h"
|
||||
#include "common/rsa_key.h"
|
||||
#include "provisioning_sdk/internal/certificates/test_oem_certificates.h"
|
||||
|
||||
namespace widevine {
|
||||
|
||||
class OemDeviceCertTest : public ::testing::Test {
|
||||
protected:
|
||||
void SetUp() override {
|
||||
ASSERT_TRUE(oem_device_cert_.Initialize(kCertTesting));
|
||||
ASSERT_TRUE(oem_device_cert_.Initialize(kCertificateTypeTesting));
|
||||
}
|
||||
|
||||
OemDeviceCert oem_device_cert_;
|
||||
TestCertificates test_certificates_;
|
||||
TestOemCertificates test_oem_certificates_;
|
||||
};
|
||||
|
||||
TEST_F(OemDeviceCertTest, EmptyCertificateChain) {
|
||||
@@ -45,7 +46,7 @@ TEST_F(OemDeviceCertTest, OnlyOneCertificateInCertificateChain) {
|
||||
uint32_t system_id;
|
||||
std::string oem_ca_serial_number;
|
||||
EXPECT_FALSE(oem_device_cert_.VerifyCertificateChain(
|
||||
test_certificates_.single_certificate_chain_der(), &leaf_public_key,
|
||||
test_oem_certificates_.single_certificate_chain_der(), &leaf_public_key,
|
||||
&system_id, &oem_ca_serial_number));
|
||||
}
|
||||
|
||||
@@ -54,11 +55,11 @@ TEST_F(OemDeviceCertTest, ValidCertificateChain) {
|
||||
uint32_t system_id;
|
||||
std::string oem_ca_serial_number;
|
||||
ASSERT_TRUE(oem_device_cert_.VerifyCertificateChain(
|
||||
test_certificates_.valid_certificate_chain_der(), &leaf_public_key,
|
||||
test_oem_certificates_.valid_certificate_chain_der(), &leaf_public_key,
|
||||
&system_id, &oem_ca_serial_number));
|
||||
|
||||
std::unique_ptr<RsaPublicKey> public_key(RsaPublicKey::Create(
|
||||
test_certificates_.valid_certificate_public_key_der()));
|
||||
test_oem_certificates_.valid_certificate_public_key_der()));
|
||||
ASSERT_TRUE(public_key);
|
||||
EXPECT_TRUE(leaf_public_key->MatchesPublicKey(*public_key));
|
||||
EXPECT_EQ(2001u, system_id);
|
||||
@@ -70,7 +71,7 @@ TEST_F(OemDeviceCertTest, ExpiredCertificateChain) {
|
||||
uint32_t system_id;
|
||||
std::string oem_ca_serial_number;
|
||||
ASSERT_FALSE(oem_device_cert_.VerifyCertificateChain(
|
||||
test_certificates_.expired_certificate_chain_der(), &leaf_public_key,
|
||||
test_oem_certificates_.expired_certificate_chain_der(), &leaf_public_key,
|
||||
&system_id, &oem_ca_serial_number));
|
||||
}
|
||||
|
||||
@@ -79,8 +80,8 @@ TEST_F(OemDeviceCertTest, OutOfOrderCertificateChain) {
|
||||
uint32_t system_id;
|
||||
std::string oem_ca_serial_number;
|
||||
ASSERT_FALSE(oem_device_cert_.VerifyCertificateChain(
|
||||
test_certificates_.backwards_certificate_chain_der(), &leaf_public_key,
|
||||
&system_id, &oem_ca_serial_number));
|
||||
test_oem_certificates_.backwards_certificate_chain_der(),
|
||||
&leaf_public_key, &system_id, &oem_ca_serial_number));
|
||||
}
|
||||
|
||||
TEST_F(OemDeviceCertTest, CertificateChainNotSignedByRoot) {
|
||||
@@ -88,7 +89,7 @@ TEST_F(OemDeviceCertTest, CertificateChainNotSignedByRoot) {
|
||||
uint32_t system_id;
|
||||
std::string oem_ca_serial_number;
|
||||
ASSERT_FALSE(oem_device_cert_.VerifyCertificateChain(
|
||||
test_certificates_.invalid_certificate_chain_der(), &leaf_public_key,
|
||||
test_oem_certificates_.invalid_certificate_chain_der(), &leaf_public_key,
|
||||
&system_id, &oem_ca_serial_number));
|
||||
}
|
||||
|
||||
|
||||
Reference in New Issue
Block a user