widevine-partner/android
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix uninitialized variable in Provisioning40CastRoundTrip

Browse Source 
- Initialize allowed_schemes_ since it is used by CreateDefaultResponse.
- Issue was detected by Coverity.

Change-Id: I368c4773f6316b65196aaa39e23e70717299c570
This commit is contained in:
Ian Benz
2024-01-25 14:26:58 +00:00
committed by Robert Shih
parent 35cf9c2f99
commit 8e48e36554
1 changed files with 8 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
libwvdrmengine/oemcrypto/test/oec_session_util.h
View File

@@ -337,8 +337,8 @@ class Provisioning40RoundTrip
// Not used. Use Load*CertResponse() below to load OEM/DRM response // Not used. Use Load*CertResponse() below to load OEM/DRM response
// respectively. // respectively.
void CreateDefaultResponse() override{}; void CreateDefaultResponse() override {};
void EncryptAndSignResponse() override{}; void EncryptAndSignResponse() override {};
OEMCryptoResult LoadResponse(Session* session) override { OEMCryptoResult LoadResponse(Session* session) override {
return OEMCrypto_ERROR_NOT_IMPLEMENTED; return OEMCrypto_ERROR_NOT_IMPLEMENTED;
} }
@@ -382,8 +382,10 @@ class Provisioning40CastRoundTrip
/* ResponseData */ RSAPrivateKeyMessage> { /* ResponseData */ RSAPrivateKeyMessage> {
public: public:
Provisioning40CastRoundTrip(Session* session, Provisioning40CastRoundTrip(Session* session,
const std::vector<uint8_t>& encoded_rsa_key) const std::vector<uint8_t>& encoded_rsa_key)
: RoundTrip(session), encryptor_(), : RoundTrip(session),
allowed_schemes_(kSign_RSASSA_PSS),
encryptor_(),
encoded_rsa_key_(encoded_rsa_key) {} encoded_rsa_key_(encoded_rsa_key) {}
void PrepareSession(); void PrepareSession();
@@ -393,7 +395,8 @@ class Provisioning40CastRoundTrip
void EncryptAndSignResponse() override; void EncryptAndSignResponse() override;
OEMCryptoResult LoadResponse() override { return LoadResponse(session_); } OEMCryptoResult LoadResponse() override { return LoadResponse(session_); }
OEMCryptoResult LoadResponse(Session* session) override; OEMCryptoResult LoadResponse(Session* session) override;
OEMCryptoResult LoadResponseNoRetry(Session* session, size_t* wrapped_key_length) ; OEMCryptoResult LoadResponseNoRetry(Session* session,
size_t* wrapped_key_length);
// Returned // Returned
const std::vector<uint8_t>& wrapped_drm_key() { return wrapped_drm_key_; } const std::vector<uint8_t>& wrapped_drm_key() { return wrapped_drm_key_; }