Merge "Address review comments" into sc-dev

This commit is contained in:
TreeHugger Robot
2021-04-17 03:49:56 +00:00
committed by Android (Google) Code Review
2 changed files with 6 additions and 6 deletions

View File

@@ -1055,7 +1055,7 @@ class RenewalTest : public CdmDurationTest {
std::string http_response;
// Most of the network latency will probably show up in the next few
// commands. I think the tests have enough slop to account for reasonable
// latency with the current value of kRoundTripTime. But We'll know I made a
// latency with the current value of kRoundTripTime. But we'll know I made a
// mistake if we see errors about "Test Clock skew..." in the SleepUntil
// call below.
ASSERT_TRUE(renewal_in_flight_->GetResponse(&http_response));

View File

@@ -81,11 +81,11 @@ the ODK functions as described in the document "License Duration and Renewal".
### What to expect from these tests
* `OEMCryptoMemory*` tests are designed to fail if API doesn't have enough
validations around input buffer lengths, parameters or OEMCryptoSubstring
struct. If the API doesn't have validations which might lead to a crash, the
test fails with a segfault or an appropriate crash message based on the API
implementation.
* `OEMCryptoMemory*` tests are designed to fail if the API doesn't have
enough validations around input buffer lengths, parameters or the
OEMCryptoSubstring struct. If the API doesn't have validations which might
lead to a crash, the test fails with a segfault or an appropriate crash
message based on the API implementation.
* Find out for what buffer length, the API is crashing and then debugging the
test against the OEMCrypto implementation should be able to provide