Merge "Address review comments" into sc-dev am: 9c3c076cac
Original change: https://googleplex-android-review.googlesource.com/c/platform/vendor/widevine/+/14207160 Change-Id: Ibde98424546e05dae4f33abf73d3483aff486814
This commit is contained in:
@@ -1055,7 +1055,7 @@ class RenewalTest : public CdmDurationTest {
|
|||||||
std::string http_response;
|
std::string http_response;
|
||||||
// Most of the network latency will probably show up in the next few
|
// Most of the network latency will probably show up in the next few
|
||||||
// commands. I think the tests have enough slop to account for reasonable
|
// commands. I think the tests have enough slop to account for reasonable
|
||||||
// latency with the current value of kRoundTripTime. But We'll know I made a
|
// latency with the current value of kRoundTripTime. But we'll know I made a
|
||||||
// mistake if we see errors about "Test Clock skew..." in the SleepUntil
|
// mistake if we see errors about "Test Clock skew..." in the SleepUntil
|
||||||
// call below.
|
// call below.
|
||||||
ASSERT_TRUE(renewal_in_flight_->GetResponse(&http_response));
|
ASSERT_TRUE(renewal_in_flight_->GetResponse(&http_response));
|
||||||
|
|||||||
@@ -81,11 +81,11 @@ the ODK functions as described in the document "License Duration and Renewal".
|
|||||||
|
|
||||||
### What to expect from these tests
|
### What to expect from these tests
|
||||||
|
|
||||||
* `OEMCryptoMemory*` tests are designed to fail if API doesn't have enough
|
* `OEMCryptoMemory*` tests are designed to fail if the API doesn't have
|
||||||
validations around input buffer lengths, parameters or OEMCryptoSubstring
|
enough validations around input buffer lengths, parameters or the
|
||||||
struct. If the API doesn't have validations which might lead to a crash, the
|
OEMCryptoSubstring struct. If the API doesn't have validations which might
|
||||||
test fails with a segfault or an appropriate crash message based on the API
|
lead to a crash, the test fails with a segfault or an appropriate crash
|
||||||
implementation.
|
message based on the API implementation.
|
||||||
|
|
||||||
* Find out for what buffer length, the API is crashing and then debugging the
|
* Find out for what buffer length, the API is crashing and then debugging the
|
||||||
test against the OEMCrypto implementation should be able to provide
|
test against the OEMCrypto implementation should be able to provide
|
||||||
|
|||||||
Reference in New Issue
Block a user